Skip to content

Adding Armstrong number #1708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 22, 2020
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions maths/armstrong_numbers.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@ def armstrong_number(n):
This function checks if a number is Armstrong or not.

>>> armstrong_number(153)
153 is an Armstrong number
True
>>> armstrong_number(200)
200 is not an Armstrong number
False
>>> armstrong_number(1634)
1634 is an Armstrong number
True
"""
# Initialization of sum and number of digits.
sum = 0
Expand All @@ -30,15 +30,19 @@ def armstrong_number(n):
sum = sum + (rem ** number_of_digits)
temp //= 10
if n == sum:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return n == sum

print(n, "is an Armstrong number")
else:
print(n, "is not an Armstrong number")
return True

return False


# In main function user inputs a number to find out if it's an Armstrong or not. Th function armstrong_number is called.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a new pull request that fixes this comment that goes off the screen?

Lines should be limited to 88 characters and the first word in the second sentence is a typo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

def main():
num = int(input("Enter a number to check if it is Armstrong or not: ").strip())
armstrong_number(num)
if armstrong_number(num):
print(num, " is an Armstrong number")
else:
print(num, " is not an Armstrong number")


if __name__ == '__main__':
Expand Down