Skip to content

Create factorial_iterative.py #1693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 18, 2020
Merged

Create factorial_iterative.py #1693

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bd96a91
Create factorial_iterative.py
pooja-git11 Jan 17, 2020
7da46aa
Update factorial_iterative.py
pooja-git11 Jan 17, 2020
648e170
Update factorial_iterative.py
pooja-git11 Jan 18, 2020
9f75648
Update factorial_iterative.py
pooja-git11 Jan 18, 2020
2a96cfc
print(f"factorial{n} is {factorial(n)}")
cclauss Jan 18, 2020
ab332a7
Update factorial_recursive.py
cclauss Jan 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions maths/factorial_iterative.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,13 @@


n=int(input("Enter a number"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line will fail our automated testing unless it is indented under if __name__ == "__main__": as discussed in CONTRIBUTING.md


def factorial(n):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See other functions in this repo to see how type hints and doctests work. They are required.

fact=1
Copy link
Member

@cclauss cclauss Jan 17, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function should raise a ValueError just like math.factorial() does:

% python3

>>> import math
>>> math.factorial(-1)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ValueError: factorial() not defined for negative values

for i in range(1,n+1):
fact*=i
return fact

print(factorial(n))
if n>=0:
print(factorial(n))
else:
print("number should be positive")