Skip to content

some pytest on math folder #1405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 21, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions maths/3n+1.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,14 @@ def main():
)
)

def testn31():
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_n31() please. Also, please remove blank lines 37 and 39.

assert n31(4) == ([4, 2, 1], 3)

assert n31(11) == ([11, 34, 17, 52, 26, 13, 40, 20, 10, 5, 16, 8, 4, 2, 1], 15)

assert n31(31) == ([31, 94, 47, 142, 71, 214, 107, 322, 161, 484, 242, 121, 364, 182, 91, 274, 137, 412, 206, 103, 310, 155, 466, 233, 700, 350, 175, 526, 263, 790, 395, 1186, 593, 1780, 890, 445, 1336, 668, 334, 167, 502, 251, 754, 377, 1132, 566, 283, 850, 425, 1276, 638, 319, 958, 479, 1438, 719, 2158, 1079, 3238, 1619, 4858, 2429, 7288, 3644, 1822, 911, 2734, 1367, 4102, 2051, 6154, 3077, 9232, 4616, 2308, 1154, 577, 1732, 866, 433, 1300, 650, 325, 976, 488, 244, 122, 61, 184, 92, 46, 23, 70, 35, 106, 53, 160, 80, 40, 20, 10, 5, 16, 8, 4, 2, 1], 107)

if __name__ == "__main__":
main()
testn31()

8 changes: 8 additions & 0 deletions maths/abs.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,13 @@ def main():
print(abs_val(-34)) # = 34


def testAbs():
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_abs_val() please. Also, please remove blank lines 23 and 25.

assert 0 == abs_val(0)

assert 34 == abs_val(34)

assert 100000000000 == abs_val(-100000000000)

if __name__ == "__main__":
main()
testAbs()
8 changes: 8 additions & 0 deletions maths/average_mean.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,13 @@ def main():
print(average([2, 4, 6, 8, 20, 50, 70]))


def testAverage():
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_average() please. Also, please remove blank lines 17 and 19.

assert 12.0 == average([3, 6, 9, 12, 15, 18, 21])

assert 20 == average([5, 10, 15, 20, 25, 30, 35])

assert 4.5 == average([1, 2, 3, 4, 5, 6, 7, 8])

if __name__ == "__main__":
main()
testAverage()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave just one blank line at the end of Python files.