Skip to content

Create greedy.py #1359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 22, 2019
Merged

Create greedy.py #1359

merged 4 commits into from
Oct 22, 2019

Conversation

DanishSheikh1999
Copy link
Contributor

No description provided.

@QuantumNovice
Copy link
Contributor

Please resolve

==================================== ERRORS ====================================


_______________________ ERROR collecting other/greedy.py _______________________

other/greedy.py:39: in <module>

    foods=build_menu(food,value,weight)

other/greedy.py:20: in build_menu

    menu.append(things(name[i],value[i],weight[i]))

E   TypeError: things() takes no arguments

@cclauss
Copy link
Member

cclauss commented Oct 18, 2019

Looking good. Could you please reformat the code with black and add a doctest or two? See CONTRIBUTING.md for details.

Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test seems to spend 570 on a budget of 500 but with no docs it is difficult to says if this is a bug or not.

@cclauss cclauss merged commit 13802fc into TheAlgorithms:master Oct 22, 2019
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
* Create greedy.py

* Update greedy.py

* Add a doctest and format with black

* Update build_directory_md.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants