Added Testcases to scoring_functions.py #1299
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Conflicting files and failing tests. |
cclauss
requested changes
Oct 7, 2019
arithmetic_analysis/bisection.py
Outdated
| def bisection(function, a, b): # finds where the function becomes 0 in [a,b] using bolzano | ||
| def bisection( | ||
| function, a, b | ||
| ): # finds where the function becomes 0 in [a,b] using bolzano |
There was a problem hiding this comment.
Please convert this comment to a docstring.
arithmetic_analysis/bisection.py
Outdated
| elif function(a) * function(b) > 0: # if none of these are root and they are both positive or negative, | ||
| elif ( | ||
| function(a) * function(b) > 0 | ||
| ): # if none of these are root and they are both positive or negative, |
There was a problem hiding this comment.
Please put this comment on a separate line.
arithmetic_analysis/intersection.py
Outdated
|
|
||
| def intersection( | ||
| function, x0, x1 | ||
| ): # function is the f we want to find its root and x0 and x1 are two random starting points |
There was a problem hiding this comment.
Please convert this comment to a docstring.
|
This PR is insane. Something is wrong. I only changed 1 file. What the frick!? |
|
Closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in response to #1085 asking for doctests. I have added doctests to all functions in
scoring_functions.py