maths-polynomial_evalutation #1214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
reviewed
Sep 30, 2019
maths/polynomial_evaluation.py
Outdated
| """ | ||
| i = 0 | ||
| res = 0 | ||
| for c in poly: |
There was a problem hiding this comment.
for i, c in enumerate(poly): # then delete lines 14 and 10
There was a problem hiding this comment.
Actually, the whole function can be a one-liner: return sum(c * x ** i for i, c in enumerate(poly))
cclauss
reviewed
Sep 30, 2019
| poly: tuple of numbers - value of cofficients | ||
| x: value for x in f(x) | ||
| Return: value of f(x) | ||
| """ |
There was a problem hiding this comment.
Please add a doctest:
>>> evaluate_poly((0.0, 0.0, 5.0, 9.3, 7.0), 10)
79800.0
Then makes sure it passes locally with: python3 -m doctest -v maths/polynomial_evaluation.py
There was a problem hiding this comment.
@cclauss thanks for the suggestion!
will do the changes.
|
@cclauss you can review the changes now. |
cclauss
approved these changes
Oct 1, 2019
There was a problem hiding this comment.
Tests are passing https://travis-ci.org/TheAlgorithms/Python/builds/591848844#L670
Thanks for your contribution. Congratulations!
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* maths-polynomial_evalutation * added doctest and removed redundancy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code for evaluating a polynomail f(x) for a value of x.