Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add algorithm 95 to find the longest amicable chain #12113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add algorithm 95 to find the longest amicable chain #12113
Changes from 12 commits
1eee73b
3349351
a450acb
7679c20
ab3769c
0d963a1
f467350
96be505
89e57b6
021fefa
f4c0a23
ebccfe3
c501b3b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 4 in project_euler/problem_095/sol1.py
Ruff (W291)
Check failure on line 5 in project_euler/problem_095/sol1.py
Ruff (W291)
Check failure on line 6 in project_euler/problem_095/sol1.py
Ruff (W291)
Check failure on line 9 in project_euler/problem_095/sol1.py
Ruff (W291)
Check failure on line 10 in project_euler/problem_095/sol1.py
Ruff (W291)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function:
sum_of_proper_divisors
. If the function does not return a value, please provide the type hint as:def function() -> None:
As there is no test file in this pull request nor any test function or class in the file
project_euler/problem_095/sol1.py
, please provide doctest for the functionsum_of_proper_divisors
Please provide type hint for the parameter:
n
Please provide descriptive name for the parameter:
n
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function:
sum_of_proper_divisors
. If the function does not return a value, please provide the type hint as:def function() -> None:
As there is no test file in this pull request nor any test function or class in the file
project_euler/problem_095/sol1.py
, please provide doctest for the functionsum_of_proper_divisors
Please provide type hint for the parameter:
n
Please provide descriptive name for the parameter:
n
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function:
find_longest_amicable_chain
. If the function does not return a value, please provide the type hint as:def function() -> None:
As there is no test file in this pull request nor any test function or class in the file
project_euler/problem_095/sol1.py
, please provide doctest for the functionfind_longest_amicable_chain
Please provide type hint for the parameter:
limit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's okay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function:
find_longest_amicable_chain
. If the function does not return a value, please provide the type hint as:def function() -> None:
As there is no test file in this pull request nor any test function or class in the file
project_euler/problem_095/sol1.py
, please provide doctest for the functionfind_longest_amicable_chain
Please provide type hint for the parameter:
limit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function:
find_longest_amicable_chain
. If the function does not return a value, please provide the type hint as:def function() -> None:
As there is no test file in this pull request nor any test function or class in the file
project_euler/problem_095/sol1.py
, please provide doctest for the functionfind_longest_amicable_chain
Please provide type hint for the parameter:
limit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function:
solution
. If the function does not return a value, please provide the type hint as:def function() -> None:
As there is no test file in this pull request nor any test function or class in the file
project_euler/problem_095/sol1.py
, please provide doctest for the functionsolution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's okay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function:
solution
. If the function does not return a value, please provide the type hint as:def function() -> None:
As there is no test file in this pull request nor any test function or class in the file
project_euler/problem_095/sol1.py
, please provide doctest for the functionsolution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function:
solution
. If the function does not return a value, please provide the type hint as:def function() -> None:
As there is no test file in this pull request nor any test function or class in the file
project_euler/problem_095/sol1.py
, please provide doctest for the functionsolution