solved the issue #12046 and #12020 #12057

iz-Manik · 2024-10-14T09:53:45Z

Describe your change:

✔Add an algorithm
✖ Fix a bug or typo in an existing algorithm?
✖ Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
✖ Documentation change?

Checklist:

✔ I have read CONTRIBUTING.md.
✔This pull request is all my own work -- I have not plagiarized.
✔ I know that pull requests will not be merged if they fail the automated tests.
✔ This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
✔ All new Python files are placed inside an existing directory.
✔ All filenames are in all lowercase characters with no spaces or dashes.
✔ All functions and variable names follow Python naming conventions.
✔ All function parameters and return values are annotated with Python type hints.
✔ All functions have doctests that pass the automated testing.
✔ All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
✔ If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

for more information, see https://pre-commit.ci

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2024-10-14T10:01:16Z

divide_and_conquer/quicksort.py

@@ -0,0 +1,48 @@
+# Function to perform partition of the array
+def partition(arr, low, high):


As there is no test file in this pull request nor any test function or class in the file divide_and_conquer/quicksort.py, please provide doctest for the function partition

Please provide return type hint for the function: partition. If the function does not return a value, please provide the type hint as: def function() -> None:

Please provide type hint for the parameter: arr

Please provide type hint for the parameter: low

Please provide type hint for the parameter: high

algorithms-keeper · 2024-10-14T10:01:16Z

divide_and_conquer/quicksort.py

+
+
+# Function to implement Quick Sort
+def quick_sort(arr, low, high):


As there is no test file in this pull request nor any test function or class in the file divide_and_conquer/quicksort.py, please provide doctest for the function quick_sort

Please provide return type hint for the function: quick_sort. If the function does not return a value, please provide the type hint as: def function() -> None:

Please provide type hint for the parameter: arr

Please provide type hint for the parameter: low

Please provide type hint for the parameter: high

algorithms-keeper · 2024-10-14T10:01:17Z

graphs/kruskal.py

@@ -0,0 +1,94 @@
+# Class to represent a graph
+class Graph:
+    def __init__(self, vertices):


Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:

Please provide type hint for the parameter: vertices

algorithms-keeper · 2024-10-14T10:01:17Z

graphs/kruskal.py

+        self.graph = []  # List to store graph edges (u, v, w)
+
+    # Function to add an edge to the graph (u -> v with weight w)
+    def add_edge(self, u, v, w):


As there is no test file in this pull request nor any test function or class in the file graphs/kruskal.py, please provide doctest for the function add_edge

Please provide return type hint for the function: add_edge. If the function does not return a value, please provide the type hint as: def function() -> None:

Please provide descriptive name for the parameter: u

Please provide type hint for the parameter: u

Please provide descriptive name for the parameter: v

Please provide type hint for the parameter: v

Please provide descriptive name for the parameter: w

Please provide type hint for the parameter: w

algorithms-keeper · 2024-10-14T10:01:17Z

graphs/kruskal.py

+        self.graph.append([u, v, w])
+
+    # Utility function to find set of an element i (uses path compression)
+    def find(self, parent, i):


As there is no test file in this pull request nor any test function or class in the file graphs/kruskal.py, please provide doctest for the function find

Please provide return type hint for the function: find. If the function does not return a value, please provide the type hint as: def function() -> None:

Please provide type hint for the parameter: parent

Please provide descriptive name for the parameter: i

Please provide type hint for the parameter: i

algorithms-keeper · 2024-10-14T10:01:17Z

graphs/kruskal.py

+        return self.find(parent, parent[i])
+
+    # Function that does union of two sets of x and y (uses union by rank)
+    def union(self, parent, rank, x, y):


As there is no test file in this pull request nor any test function or class in the file graphs/kruskal.py, please provide doctest for the function union

Please provide return type hint for the function: union. If the function does not return a value, please provide the type hint as: def function() -> None:

Please provide type hint for the parameter: parent

Please provide type hint for the parameter: rank

Please provide descriptive name for the parameter: x

Please provide type hint for the parameter: x

Please provide descriptive name for the parameter: y

Please provide type hint for the parameter: y

algorithms-keeper · 2024-10-14T10:01:17Z

graphs/kruskal.py

+            rank[root_x] += 1
+
+    # Main function to construct MST using Kruskal's algorithm
+    def kruskal_mst(self):


As there is no test file in this pull request nor any test function or class in the file graphs/kruskal.py, please provide doctest for the function kruskal_mst

Please provide return type hint for the function: kruskal_mst. If the function does not return a value, please provide the type hint as: def function() -> None:

for more information, see https://pre-commit.ci

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2024-10-14T10:16:12Z

divide_and_conquer/quicksort.py

+        quick_sort(arr, low, pi - 1)
+        quick_sort(arr, pi + 1, high)
+
+def partition(arr: List[int], low: int, high: int) -> int:


As there is no test file in this pull request nor any test function or class in the file divide_and_conquer/quicksort.py, please provide doctest for the function partition

for more information, see https://pre-commit.ci

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2024-10-14T10:29:56Z

divide_and_conquer/quicksort.py

+        quick_sort(arr, low, pi - 1)
+        quick_sort(arr, pi + 1, high)
+
+def partition(arr: list[int], low: int, high: int) -> int:


As there is no test file in this pull request nor any test function or class in the file divide_and_conquer/quicksort.py, please provide doctest for the function partition

for more information, see https://pre-commit.ci

iz-Manik · 2024-10-14T10:37:44Z

Please review this PR.

cclauss · 2024-11-01T08:11:31Z

Closing require_tests PRs to prepare for Hacktoberfest

iz-Manik and others added 2 commits October 14, 2024 15:19

Added code for quicksort.py and kruskal algorithm

d65aecf

[pre-commit.ci] auto fixes from pre-commit.com hooks

7eb6984

for more information, see https://pre-commit.ci

algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 14, 2024

Update kruskal.py

24bcc2e

algorithms-keeper bot added require descriptive names This PR needs descriptive function and/or variable names require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Oct 14, 2024

algorithms-keeper bot reviewed Oct 14, 2024

View reviewed changes

algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 14, 2024

[pre-commit.ci] auto fixes from pre-commit.com hooks

f0f2213

for more information, see https://pre-commit.ci

algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 14, 2024

iz-Manik added 2 commits October 14, 2024 15:44

updated requirements to solve issue

d3402ee

updated requirements

d425012

algorithms-keeper bot removed require descriptive names This PR needs descriptive function and/or variable names require type hints https://docs.python.org/3/library/typing.html labels Oct 14, 2024

algorithms-keeper bot reviewed Oct 14, 2024

View reviewed changes

[pre-commit.ci] auto fixes from pre-commit.com hooks

8e56553

for more information, see https://pre-commit.ci

algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 14, 2024

isssue resolved

b492d5f

algorithms-keeper bot reviewed Oct 14, 2024

View reviewed changes

[pre-commit.ci] auto fixes from pre-commit.com hooks

9e8d831

for more information, see https://pre-commit.ci

algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 14, 2024

cclauss closed this Nov 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

solved the issue #12046 and #12020 #12057

solved the issue #12046 and #12020 #12057

iz-Manik commented Oct 14, 2024 •

edited

Loading

algorithms-keeper bot left a comment

algorithms-keeper bot Oct 14, 2024

algorithms-keeper bot Oct 14, 2024

algorithms-keeper bot Oct 14, 2024

algorithms-keeper bot Oct 14, 2024

algorithms-keeper bot Oct 14, 2024

algorithms-keeper bot Oct 14, 2024

algorithms-keeper bot Oct 14, 2024

algorithms-keeper bot left a comment

algorithms-keeper bot Oct 14, 2024

algorithms-keeper bot left a comment

algorithms-keeper bot Oct 14, 2024

iz-Manik commented Oct 14, 2024

cclauss commented Nov 1, 2024

		@@ -0,0 +1,48 @@
		# Function to perform partition of the array
		def partition(arr, low, high):



		# Function to implement Quick Sort
		def quick_sort(arr, low, high):

solved the issue #12046 and #12020 #12057

solved the issue #12046 and #12020 #12057

Conversation

iz-Manik commented Oct 14, 2024 • edited Loading

Describe your change:

Checklist:

algorithms-keeper bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

algorithms-keeper bot Oct 14, 2024

Choose a reason for hiding this comment

algorithms-keeper bot Oct 14, 2024

Choose a reason for hiding this comment

algorithms-keeper bot Oct 14, 2024

Choose a reason for hiding this comment

algorithms-keeper bot Oct 14, 2024

Choose a reason for hiding this comment

algorithms-keeper bot Oct 14, 2024

Choose a reason for hiding this comment

algorithms-keeper bot Oct 14, 2024

Choose a reason for hiding this comment

algorithms-keeper bot Oct 14, 2024

Choose a reason for hiding this comment

algorithms-keeper bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

algorithms-keeper bot Oct 14, 2024

Choose a reason for hiding this comment

algorithms-keeper bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

algorithms-keeper bot Oct 14, 2024

Choose a reason for hiding this comment

iz-Manik commented Oct 14, 2024

cclauss commented Nov 1, 2024

iz-Manik commented Oct 14, 2024 •

edited

Loading