Skip to content

chore: Game Theory algorithms are added #11864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 17 commits into from
Closed

chore: Game Theory algorithms are added #11864

wants to merge 17 commits into from

Conversation

isatyamks
Copy link

Describe your change:

#fixed issue #11804

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes Game Theory algorithms are missing #11804".

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 7, 2024
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 7, 2024
@algorithms-keeper algorithms-keeper bot added require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Oct 7, 2024
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

@@ -0,0 +1,28 @@
import numpy as np
def best_response_dynamics(payoff_matrix_a, payoff_matrix_b, iterations=10):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: best_response_dynamics. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file game_theory/best_response_dynamics.py, please provide doctest for the function best_response_dynamics

Please provide type hint for the parameter: payoff_matrix_a

Please provide type hint for the parameter: payoff_matrix_b

Please provide type hint for the parameter: iterations

@@ -0,0 +1,33 @@
def fictitious_play(payoff_matrix_a, payoff_matrix_b, iterations=100):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: fictitious_play. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file game_theory/fictitious_play.py, please provide doctest for the function fictitious_play

Please provide type hint for the parameter: payoff_matrix_a

Please provide type hint for the parameter: payoff_matrix_b

Please provide type hint for the parameter: iterations

@@ -0,0 +1,29 @@
def minimax(depth, node_index, is_maximizing_player, values, alpha, beta):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: minimax. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file game_theory/minimax_algorithm.py, please provide doctest for the function minimax

Please provide type hint for the parameter: depth

Please provide type hint for the parameter: node_index

Please provide type hint for the parameter: is_maximizing_player

Please provide type hint for the parameter: values

Please provide type hint for the parameter: alpha

Please provide type hint for the parameter: beta

from scipy.optimize import linprog


def find_nash_equilibrium(payoff_matrix_a, payoff_matrix_b):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: find_nash_equilibrium. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file game_theory/nash_equlibrium.py, please provide doctest for the function find_nash_equilibrium

Please provide type hint for the parameter: payoff_matrix_a

Please provide type hint for the parameter: payoff_matrix_b

import numpy as np


def shapley_value(payoff_matrix):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: shapley_value. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file game_theory/shapley_value.py, please provide doctest for the function shapley_value

Please provide type hint for the parameter: payoff_matrix

Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

import numpy as np


def best_response_dynamics(payoff_matrix_a, payoff_matrix_b, iterations=10):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: best_response_dynamics. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file game_theory/best_response_dynamics.py, please provide doctest for the function best_response_dynamics

Please provide type hint for the parameter: payoff_matrix_a

Please provide type hint for the parameter: payoff_matrix_b

Please provide type hint for the parameter: iterations

@@ -0,0 +1,34 @@
import numpy as np
def fictitious_play(payoff_matrix_a, payoff_matrix_b, iterations=100):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: fictitious_play. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file game_theory/fictitious_play.py, please provide doctest for the function fictitious_play

Please provide type hint for the parameter: payoff_matrix_a

Please provide type hint for the parameter: payoff_matrix_b

Please provide type hint for the parameter: iterations

@@ -0,0 +1,29 @@
def minimax(depth, node_index, is_maximizing_player, values, alpha, beta):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: minimax. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file game_theory/minimax_algorithm.py, please provide doctest for the function minimax

Please provide type hint for the parameter: depth

Please provide type hint for the parameter: node_index

Please provide type hint for the parameter: is_maximizing_player

Please provide type hint for the parameter: values

Please provide type hint for the parameter: alpha

Please provide type hint for the parameter: beta

from scipy.optimize import linprog


def find_nash_equilibrium(payoff_matrix_a, payoff_matrix_b):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: find_nash_equilibrium. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file game_theory/nash_equlibrium.py, please provide doctest for the function find_nash_equilibrium

Please provide type hint for the parameter: payoff_matrix_a

Please provide type hint for the parameter: payoff_matrix_b

import numpy as np


def shapley_value(payoff_matrix):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: shapley_value. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file game_theory/shapley_value.py, please provide doctest for the function shapley_value

Please provide type hint for the parameter: payoff_matrix

Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

import numpy as np


def best_response_dynamics(payoff_matrix_a, payoff_matrix_b, iterations=10):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: best_response_dynamics. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file game_theory/best_response_dynamics.py, please provide doctest for the function best_response_dynamics

Please provide type hint for the parameter: payoff_matrix_a

Please provide type hint for the parameter: payoff_matrix_b

Please provide type hint for the parameter: iterations

@@ -0,0 +1,35 @@
import numpy as np

def fictitious_play(payoff_matrix_a, payoff_matrix_b, iterations=100):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: fictitious_play. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file game_theory/fictitious_play.py, please provide doctest for the function fictitious_play

Please provide type hint for the parameter: payoff_matrix_a

Please provide type hint for the parameter: payoff_matrix_b

Please provide type hint for the parameter: iterations

@@ -0,0 +1,29 @@
def minimax(depth, node_index, is_maximizing_player, values, alpha, beta):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: minimax. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file game_theory/minimax_algorithm.py, please provide doctest for the function minimax

Please provide type hint for the parameter: depth

Please provide type hint for the parameter: node_index

Please provide type hint for the parameter: is_maximizing_player

Please provide type hint for the parameter: values

Please provide type hint for the parameter: alpha

Please provide type hint for the parameter: beta

from scipy.optimize import linprog


def find_nash_equilibrium(payoff_matrix_a, payoff_matrix_b):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: find_nash_equilibrium. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file game_theory/nash_equlibrium.py, please provide doctest for the function find_nash_equilibrium

Please provide type hint for the parameter: payoff_matrix_a

Please provide type hint for the parameter: payoff_matrix_b

import numpy as np


def shapley_value(payoff_matrix):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: shapley_value. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file game_theory/shapley_value.py, please provide doctest for the function shapley_value

Please provide type hint for the parameter: payoff_matrix

Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

import numpy as np


def best_response_dynamics(payoff_matrix_a, payoff_matrix_b, iterations=10):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: best_response_dynamics. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file game_theory/best_response_dynamics.py, please provide doctest for the function best_response_dynamics

Please provide type hint for the parameter: payoff_matrix_a

Please provide type hint for the parameter: payoff_matrix_b

Please provide type hint for the parameter: iterations

import numpy as np


def fictitious_play(payoff_matrix_a, payoff_matrix_b, iterations=100):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: fictitious_play. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file game_theory/fictitious_play.py, please provide doctest for the function fictitious_play

Please provide type hint for the parameter: payoff_matrix_a

Please provide type hint for the parameter: payoff_matrix_b

Please provide type hint for the parameter: iterations

@@ -0,0 +1,29 @@
def minimax(depth, node_index, is_maximizing_player, values, alpha, beta):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: minimax. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file game_theory/minimax_algorithm.py, please provide doctest for the function minimax

Please provide type hint for the parameter: depth

Please provide type hint for the parameter: node_index

Please provide type hint for the parameter: is_maximizing_player

Please provide type hint for the parameter: values

Please provide type hint for the parameter: alpha

Please provide type hint for the parameter: beta

from scipy.optimize import linprog


def find_nash_equilibrium(payoff_matrix_a, payoff_matrix_b):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: find_nash_equilibrium. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file game_theory/nash_equlibrium.py, please provide doctest for the function find_nash_equilibrium

Please provide type hint for the parameter: payoff_matrix_a

Please provide type hint for the parameter: payoff_matrix_b

@@ -0,0 +1,28 @@
import numpy as np

def shapley_value(payoff_matrix):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: shapley_value. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file game_theory/shapley_value.py, please provide doctest for the function shapley_value

Please provide type hint for the parameter: payoff_matrix

@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 7, 2024
@isatyamks isatyamks closed this by deleting the head repository Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting reviews This PR is ready to be reviewed require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Game Theory algorithms are missing
1 participant