-
-
Notifications
You must be signed in to change notification settings - Fork 46.7k
chore: Game Theory algorithms are added #11864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper
commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper review
to trigger the checks for only added pull request files@algorithms-keeper review-all
to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
@@ -0,0 +1,28 @@ | |||
import numpy as np | |||
def best_response_dynamics(payoff_matrix_a, payoff_matrix_b, iterations=10): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function: best_response_dynamics
. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file game_theory/best_response_dynamics.py
, please provide doctest for the function best_response_dynamics
Please provide type hint for the parameter: payoff_matrix_a
Please provide type hint for the parameter: payoff_matrix_b
Please provide type hint for the parameter: iterations
@@ -0,0 +1,33 @@ | |||
def fictitious_play(payoff_matrix_a, payoff_matrix_b, iterations=100): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function: fictitious_play
. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file game_theory/fictitious_play.py
, please provide doctest for the function fictitious_play
Please provide type hint for the parameter: payoff_matrix_a
Please provide type hint for the parameter: payoff_matrix_b
Please provide type hint for the parameter: iterations
@@ -0,0 +1,29 @@ | |||
def minimax(depth, node_index, is_maximizing_player, values, alpha, beta): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function: minimax
. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file game_theory/minimax_algorithm.py
, please provide doctest for the function minimax
Please provide type hint for the parameter: depth
Please provide type hint for the parameter: node_index
Please provide type hint for the parameter: is_maximizing_player
Please provide type hint for the parameter: values
Please provide type hint for the parameter: alpha
Please provide type hint for the parameter: beta
from scipy.optimize import linprog | ||
|
||
|
||
def find_nash_equilibrium(payoff_matrix_a, payoff_matrix_b): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function: find_nash_equilibrium
. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file game_theory/nash_equlibrium.py
, please provide doctest for the function find_nash_equilibrium
Please provide type hint for the parameter: payoff_matrix_a
Please provide type hint for the parameter: payoff_matrix_b
import numpy as np | ||
|
||
|
||
def shapley_value(payoff_matrix): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function: shapley_value
. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file game_theory/shapley_value.py
, please provide doctest for the function shapley_value
Please provide type hint for the parameter: payoff_matrix
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper
commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper review
to trigger the checks for only added pull request files@algorithms-keeper review-all
to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
import numpy as np | ||
|
||
|
||
def best_response_dynamics(payoff_matrix_a, payoff_matrix_b, iterations=10): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function: best_response_dynamics
. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file game_theory/best_response_dynamics.py
, please provide doctest for the function best_response_dynamics
Please provide type hint for the parameter: payoff_matrix_a
Please provide type hint for the parameter: payoff_matrix_b
Please provide type hint for the parameter: iterations
@@ -0,0 +1,34 @@ | |||
import numpy as np | |||
def fictitious_play(payoff_matrix_a, payoff_matrix_b, iterations=100): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function: fictitious_play
. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file game_theory/fictitious_play.py
, please provide doctest for the function fictitious_play
Please provide type hint for the parameter: payoff_matrix_a
Please provide type hint for the parameter: payoff_matrix_b
Please provide type hint for the parameter: iterations
@@ -0,0 +1,29 @@ | |||
def minimax(depth, node_index, is_maximizing_player, values, alpha, beta): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function: minimax
. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file game_theory/minimax_algorithm.py
, please provide doctest for the function minimax
Please provide type hint for the parameter: depth
Please provide type hint for the parameter: node_index
Please provide type hint for the parameter: is_maximizing_player
Please provide type hint for the parameter: values
Please provide type hint for the parameter: alpha
Please provide type hint for the parameter: beta
from scipy.optimize import linprog | ||
|
||
|
||
def find_nash_equilibrium(payoff_matrix_a, payoff_matrix_b): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function: find_nash_equilibrium
. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file game_theory/nash_equlibrium.py
, please provide doctest for the function find_nash_equilibrium
Please provide type hint for the parameter: payoff_matrix_a
Please provide type hint for the parameter: payoff_matrix_b
import numpy as np | ||
|
||
|
||
def shapley_value(payoff_matrix): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function: shapley_value
. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file game_theory/shapley_value.py
, please provide doctest for the function shapley_value
Please provide type hint for the parameter: payoff_matrix
for more information, see https://pre-commit.ci
Remove unnecessary code and resolve merge conflicts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper
commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper review
to trigger the checks for only added pull request files@algorithms-keeper review-all
to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
import numpy as np | ||
|
||
|
||
def best_response_dynamics(payoff_matrix_a, payoff_matrix_b, iterations=10): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function: best_response_dynamics
. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file game_theory/best_response_dynamics.py
, please provide doctest for the function best_response_dynamics
Please provide type hint for the parameter: payoff_matrix_a
Please provide type hint for the parameter: payoff_matrix_b
Please provide type hint for the parameter: iterations
@@ -0,0 +1,35 @@ | |||
import numpy as np | |||
|
|||
def fictitious_play(payoff_matrix_a, payoff_matrix_b, iterations=100): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function: fictitious_play
. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file game_theory/fictitious_play.py
, please provide doctest for the function fictitious_play
Please provide type hint for the parameter: payoff_matrix_a
Please provide type hint for the parameter: payoff_matrix_b
Please provide type hint for the parameter: iterations
@@ -0,0 +1,29 @@ | |||
def minimax(depth, node_index, is_maximizing_player, values, alpha, beta): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function: minimax
. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file game_theory/minimax_algorithm.py
, please provide doctest for the function minimax
Please provide type hint for the parameter: depth
Please provide type hint for the parameter: node_index
Please provide type hint for the parameter: is_maximizing_player
Please provide type hint for the parameter: values
Please provide type hint for the parameter: alpha
Please provide type hint for the parameter: beta
from scipy.optimize import linprog | ||
|
||
|
||
def find_nash_equilibrium(payoff_matrix_a, payoff_matrix_b): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function: find_nash_equilibrium
. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file game_theory/nash_equlibrium.py
, please provide doctest for the function find_nash_equilibrium
Please provide type hint for the parameter: payoff_matrix_a
Please provide type hint for the parameter: payoff_matrix_b
import numpy as np | ||
|
||
|
||
def shapley_value(payoff_matrix): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function: shapley_value
. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file game_theory/shapley_value.py
, please provide doctest for the function shapley_value
Please provide type hint for the parameter: payoff_matrix
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper
commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper review
to trigger the checks for only added pull request files@algorithms-keeper review-all
to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
import numpy as np | ||
|
||
|
||
def best_response_dynamics(payoff_matrix_a, payoff_matrix_b, iterations=10): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function: best_response_dynamics
. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file game_theory/best_response_dynamics.py
, please provide doctest for the function best_response_dynamics
Please provide type hint for the parameter: payoff_matrix_a
Please provide type hint for the parameter: payoff_matrix_b
Please provide type hint for the parameter: iterations
import numpy as np | ||
|
||
|
||
def fictitious_play(payoff_matrix_a, payoff_matrix_b, iterations=100): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function: fictitious_play
. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file game_theory/fictitious_play.py
, please provide doctest for the function fictitious_play
Please provide type hint for the parameter: payoff_matrix_a
Please provide type hint for the parameter: payoff_matrix_b
Please provide type hint for the parameter: iterations
@@ -0,0 +1,29 @@ | |||
def minimax(depth, node_index, is_maximizing_player, values, alpha, beta): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function: minimax
. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file game_theory/minimax_algorithm.py
, please provide doctest for the function minimax
Please provide type hint for the parameter: depth
Please provide type hint for the parameter: node_index
Please provide type hint for the parameter: is_maximizing_player
Please provide type hint for the parameter: values
Please provide type hint for the parameter: alpha
Please provide type hint for the parameter: beta
from scipy.optimize import linprog | ||
|
||
|
||
def find_nash_equilibrium(payoff_matrix_a, payoff_matrix_b): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function: find_nash_equilibrium
. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file game_theory/nash_equlibrium.py
, please provide doctest for the function find_nash_equilibrium
Please provide type hint for the parameter: payoff_matrix_a
Please provide type hint for the parameter: payoff_matrix_b
@@ -0,0 +1,28 @@ | |||
import numpy as np | |||
|
|||
def shapley_value(payoff_matrix): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function: shapley_value
. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file game_theory/shapley_value.py
, please provide doctest for the function shapley_value
Please provide type hint for the parameter: payoff_matrix
for more information, see https://pre-commit.ci
Describe your change:
#fixed issue #11804
Checklist: