Interval scheduling #11853
Interval scheduling #11853
Conversation
algorithms-keeper
bot
added
require descriptive names
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
|
|
||
| """ | ||
|
|
||
| def interval_scheduling(stimes, ftimes): |
There was a problem hiding this comment.
Please provide return type hint for the function: interval_scheduling. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file scheduling/interval_scheduling_algorithm.py, please provide doctest for the function interval_scheduling
Please provide type hint for the parameter: stimes
Please provide type hint for the parameter: ftimes
| def interval_scheduling(stimes, ftimes): | ||
| index = list(range(len(stimes))) | ||
| # sort according to finish times | ||
| index.sort(key=lambda i: ftimes[i]) |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: i
|
|
||
|
|
||
| n = int(input('Enter number of activities: ')) | ||
| stimes = input('Enter the start time of the {} activities in order: ' |
There was a problem hiding this comment.
As mentioned in the Contributing Guidelines, please do not use printf style formatting or str.format(). Use f-string instead to be more readable and efficient.
| stimes = input('Enter the start time of the {} activities in order: ' | ||
| .format(n)).split() | ||
| stimes = [int(st) for st in stimes] | ||
| ftimes = input('Enter the finish times of the {} activities in order: ' |
There was a problem hiding this comment.
As mentioned in the Contributing Guidelines, please do not use printf style formatting or str.format(). Use f-string instead to be more readable and efficient.
algorithms-keeper
bot
added
awaiting reviews
vinaysanwal
force-pushed
the
feat/newalgo
branch
from
9811a31 to
e43a7ca
Compare
vinaysanwal
force-pushed
the
feat/newalgo
branch
from
8f0d7ee to
772d5da
Compare
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
|
|
||
|
|
||
| n = int(input('Enter number of activities: ')) | ||
| stimes = input('Enter the start time of the {} activities in order: ' |
There was a problem hiding this comment.
As mentioned in the Contributing Guidelines, please do not use printf style formatting or str.format(). Use f-string instead to be more readable and efficient.
vinaysanwal
force-pushed
the
feat/newalgo
branch
from
3bc81fd to
e810066
Compare
algorithms-keeper
bot
removed
the
require descriptive names
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
|
|
||
| """ | ||
|
|
||
| def interval_scheduling(stimes, ftimes): |
There was a problem hiding this comment.
Please provide return type hint for the function: interval_scheduling. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file scheduling/Iinterval_scheduling_algorithm.py, please provide doctest for the function interval_scheduling
Please provide type hint for the parameter: stimes
Please provide type hint for the parameter: ftimes
for more information, see https://pre-commit.ci
|
Closing require_type_hints PRs to prepare for Hacktoberfest |
Describe your change:
Interval scheduling is a class of problems. The programs take a number of tasks into account. Every task is represented by an interval that indicates the amount of time it should take a machine to complete it. If there is no overlap between any two intervals on the system or resource, a subset of intervals is compatible.
The goal of the interval scheduling maximization problem is to identify the largest compatible set or a collection of intervals with the least possible overlap. The idea is to optimize throughput by completing as many tasks as you can.
Interval Scheduling Problem:
Input – An input of n intervals {s(i), … , f(i)−1} for 1 ≤ i ≤ n where i represents the intervals, s(i) represents the start time, and f(i) represents the finish time.
Output – A schedule S of n intervals where no two intervals in S conflict, and the total number of intervals in S is maximized.
Checklist: