Add delete to trie.py + tests #1177
Conversation
|
@cclauss Can you review the pull request? |
|
|
||
| for key, value in node.nodes.items(): | ||
| print_words(value, word + key) | ||
|
|
||
|
|
||
| def test(): | ||
| words = ['banana', 'bananas', 'bandana', 'band', 'apple', 'all', 'beast'] | ||
| words = ["banana", "bananas", "bandana", "band", "apple", "all", "beast"] | ||
| root = TrieNode() | ||
| root.insert_many(words) |
There was a problem hiding this comment.
Could we test that len(the whole tree) == len(words)?
Could we add a test: assert all(root.find(word) for word in words)
There was a problem hiding this comment.
Can you elaborate on how to go about this?
There was a problem hiding this comment.
Let's forget the first request because this implementation does not have a __len__() method or a visit() method that would facilitate the creation of that test.
There was a problem hiding this comment.
assert all(root.find(word) for word in words) will ensure that we can find() each word that we just added.
There was a problem hiding this comment.
|
While we are modifying this file, can you please remove the comments __ # noqa: E999 This syntax is Python 3 only__ because this repo does not support legacy Python. |
|
Will do. @cclauss Do I need to add the test assert all(root.find(word) for word in words)? |
data_structures/trie/trie.py
Outdated
| @@ -56,20 +84,27 @@ def print_words(node: TrieNode, word: str): # noqa: E999 This syntax is Python | |||
| :return: None | |||
| """ | |||
| if node.is_leaf: | |||
| print(word, end=' ') | |||
| print(word, end=" ") | |||
|
|
|||
| for key, value in node.nodes.items(): | |||
| print_words(value, word + key) | |||
|
|
|||
|
|
|||
| def test(): | |||
There was a problem hiding this comment.
Unfortunately, our Travis CI automated tests are not finding the test() function. Can you try renaming this function to test_trie() in an attempt to satisfy https://docs.pytest.org/en/latest/goodpractices.html#test-discovery
There was a problem hiding this comment.
@cclauss Made some changes for Travis CI to detect the tests. Kindly review them. Referenced from data_structures/binary_tree/red_black_tree.py
|
Awesome work! Thanks for your contribution. |
|
Thank you @cclauss for the help. |
* Add delete to trie.py + tests * Minor fixes + tests * Remove noqa comments + modify tests for Travis CI to detect * Minor improvement
Hi, Thank you for this awesome repository. @cclauss kindly review the changes.