Skip to content

Adds Longest Arithmetic Subsequence (Review Reqd) #11712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

tejaswi0910
Copy link

@tejaswi0910 tejaswi0910 commented Oct 3, 2024

Describe your change:

Summary:
This PR adds an implementation of the Longest Arithmetic Subsequence algorithm in Python. The function computes the length of the longest arithmetic subsequence from an input list of integers.

Key Features:
Implements the function longest_arithmetic_subsequence(nums: List[int]) -> int which:
Returns the length of the longest arithmetic subsequence.
Handles edge cases like empty arrays and None input.

Changes:
Added a function to calculate the longest arithmetic subsequence, supporting dynamic programming.
Added type hints using List from the typing module for clarity and static type checking.
The algorithm returns the length of the longest subsequence while ensuring:
For an empty array, the result is 0.
For a None array, a ValueError is raised.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

Copy link
Contributor

@imSanko imSanko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it closed?

@tejaswi0910
Copy link
Author

Is it closed?

I am working on it currently, no its not closed
its a draft PR in progress

@tejaswi0910 tejaswi0910 marked this pull request as ready for review October 3, 2024 18:15
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 3, 2024
Copy link
Contributor

@imSanko imSanko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some more tests?

@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 4, 2024
@tejaswi0910
Copy link
Author

hey @tianyizheng02, can you please review this PR!

@tejaswi0910 tejaswi0910 changed the title Adds Longest Arithmetic Subsequence Adds Longest Arithmetic Subsequence (Review Reqd) Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting reviews This PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants