-
-
Notifications
You must be signed in to change notification settings - Fork 46.9k
Improve comments, add doctests for kahns_algorithm_topo.py #11668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tianyizheng02
merged 4 commits into
TheAlgorithms:master
from
Hardvan:kahns_algo_topo_improvement
Oct 4, 2024
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,36 +1,64 @@ | ||
def topological_sort(graph): | ||
def topological_sort(graph: dict[int, list[int]]) -> list[int] | None: | ||
""" | ||
Kahn's Algorithm is used to find Topological ordering of Directed Acyclic Graph | ||
using BFS | ||
Perform topological sorting of a Directed Acyclic Graph (DAG) | ||
using Kahn's Algorithm via Breadth-First Search (BFS). | ||
|
||
Topological sorting is a linear ordering of vertices in a graph such that for | ||
every directed edge u → v, vertex u comes before vertex v in the ordering. | ||
|
||
Parameters: | ||
graph: Adjacency list representing the directed graph where keys are | ||
vertices, and values are lists of adjacent vertices. | ||
|
||
Returns: | ||
The topologically sorted order of vertices if the graph is a DAG. | ||
Returns None if the graph contains a cycle. | ||
|
||
Example: | ||
>>> graph = {0: [1, 2], 1: [3], 2: [3], 3: [4, 5], 4: [], 5: []} | ||
>>> topological_sort(graph) | ||
[0, 1, 2, 3, 4, 5] | ||
|
||
>>> graph_with_cycle = {0: [1], 1: [2], 2: [0]} | ||
>>> topological_sort(graph_with_cycle) | ||
Cycle exists | ||
""" | ||
|
||
# Initialize indegree array | ||
indegree = [0] * len(graph) | ||
queue = [] | ||
topo = [] | ||
cnt = 0 | ||
topo = [] # topological order of vertices | ||
cnt = 0 # no. of vertices processed | ||
|
||
# Calculate the indegree of each vertex | ||
for values in graph.values(): | ||
for i in values: | ||
indegree[i] += 1 | ||
|
||
# Add all vertices with 0 indegree to the queue | ||
for i in range(len(indegree)): | ||
if indegree[i] == 0: | ||
queue.append(i) | ||
|
||
# Perform BFS | ||
while queue: | ||
vertex = queue.pop(0) | ||
cnt += 1 | ||
topo.append(vertex) | ||
for x in graph[vertex]: | ||
indegree[x] -= 1 | ||
if indegree[x] == 0: | ||
queue.append(x) | ||
|
||
# Traverse neighbors | ||
for neighbor in graph[vertex]: | ||
indegree[neighbor] -= 1 | ||
if indegree[neighbor] == 0: | ||
queue.append(neighbor) | ||
|
||
if cnt != len(graph): | ||
print("Cycle exists") | ||
Hardvan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
else: | ||
print(topo) | ||
return None # no topological ordering exists | ||
return topo # valid topological ordering | ||
|
||
|
||
if __name__ == "__main__": | ||
import doctest | ||
|
||
# Adjacency List of Graph | ||
graph = {0: [1, 2], 1: [3], 2: [3], 3: [4, 5], 4: [], 5: []} | ||
topological_sort(graph) | ||
doctest.testmod() |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.