Skip to content

feat: Implemented Matrix Exponentiation Method #11636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 27 commits into from
Closed

feat: Implemented Matrix Exponentiation Method #11636

wants to merge 27 commits into from

Conversation

Acuspeedster
Copy link
Contributor

@Acuspeedster Acuspeedster commented Oct 1, 2024 •
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@Acuspeedster
feat: add Matrix Exponentiation method
f5211cc 
docs: updated the header documentation and added new documentation for
the new function.
@Acuspeedster
feat: added new function matrix exponetiation method
95421d7
@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 1, 2024
@Acuspeedster
Copy link
Contributor Author

Please Review this pull request

@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 1, 2024
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 1, 2024
@algorithms-keeper algorithms-keeper bot added the require descriptive names This PR needs descriptive function and/or variable names label Oct 1, 2024
algorithms-keeper[bot]
algorithms-keeper bot reviewed Oct 1, 2024
View reviewed changes
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 1, 2024
@algorithms-keeper algorithms-keeper bot removed require descriptive names This PR needs descriptive function and/or variable names tests are failing Do not merge until tests pass labels Oct 1, 2024
@Acuspeedster
Copy link
Contributor Author

Rectified the code, Review it once more.

tianyizheng02
tianyizheng02 requested changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@tianyizheng02 tianyizheng02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think your implementation could be improved by using numpy's ndarray for matrices. I believe numpy's operations are faster, and you don't need to implement matrix multiplication.

@tianyizheng02 tianyizheng02 added awaiting changes A maintainer has requested changes to this PR require tests Tests [doctest/unittest/pytest] are required and removed awaiting reviews This PR is ready to be reviewed labels Oct 1, 2024
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 2, 2024
@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Oct 2, 2024
@algorithms-keeper algorithms-keeper bot removed the require tests Tests [doctest/unittest/pytest] are required label Oct 2, 2024
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 2, 2024
@Acuspeedster
Copy link
Contributor Author

@tianyizheng02 Please review this again.

@Acuspeedster
Copy link
Contributor Author

I think your implementation could be improved by using numpy's ndarray for matrices. I believe numpy's operations are faster, and you don't need to implement matrix multiplication.

already done with the changes

tianyizheng02
tianyizheng02 requested changes Oct 4, 2024
View reviewed changes
maths/fibonacci.py
return np.dot(a, b)


def matrix_pow_np(m: ndarray, power: int) -> ndarray:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we have unit tests for this function as well?

@tianyizheng02 tianyizheng02 added awaiting changes A maintainer has requested changes to this PR require tests Tests [doctest/unittest/pytest] are required and removed awaiting reviews This PR is ready to be reviewed labels Oct 4, 2024
@Acuspeedster @tianyizheng02
Update maths/fibonacci.py
955c792 
Co-authored-by: Tianyi Zheng <[email protected]>
@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed and removed require tests Tests [doctest/unittest/pytest] are required awaiting changes A maintainer has requested changes to this PR labels Oct 4, 2024
@Acuspeedster
Copy link
Contributor Author

something unusual with the test running

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@algorithms-keeper algorithms-keeper[bot] algorithms-keeper[bot] left review comments

@tianyizheng02 tianyizheng02 Awaiting requested review from tianyizheng02

Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Acuspeedster @tianyizheng02