Update DIRECTORY #1161
Merged
Update DIRECTORY #1161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
requested changes
Aug 30, 2019
cclauss
requested changes
Sep 5, 2019
|
Just saw the URL problem, will fix it |
cclauss
reviewed
Sep 5, 2019
| @@ -36,7 +36,7 @@ def print_directory_md(top_dir: str = ".") -> None: | |||
| if filepath != old_path: | |||
| old_path = print_path(old_path, filepath) | |||
| indent = (filepath.count(os.sep) + 1) if filepath else 0 | |||
| url = "/".join((URL_BASE, filepath, filename)).replace(" ", "%20") | |||
| url = "/".join((URL_BASE, filepath.split(os.sep)[1], filename)).replace(" ", "%20") | |||
There was a problem hiding this comment.
These are URLs which always use slashes. os.sep on Windows is a backslash which is not a good idea in a URL.
There was a problem hiding this comment.
I used os.sep to remove the back slashes in filepath
Before that filepath were something like "\\folder" and that's why bad URLs were generated.
cclauss
approved these changes
Sep 6, 2019
cclauss
added a commit
that referenced
this pull request
Oct 3, 2019
Revert #1161 because it broke our output: https://travis-ci.org/TheAlgorithms/Python/builds/592863893#L805
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* Update DIRECTORY * Updated DIRECTORY * Fixed bug in directory build and re-build the directory.md * fixed url issue * fixed indentation in Directory.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Index more problems from sections like