Skip to content

Update pairs_with_given_sum.py #11549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Update pairs_with_given_sum.py #11549

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 3, 2024

Dictionary Usage:

We use a dictionary seen to keep track of the number of times each number has appeared so far. For each number num in the array, we calculate its complement (req_sum - num). If this complement has been seen before, then it means there are pairs that sum up to req_sum, and we add the count of such complements to our count. Efficiency:

This approach processes each element of the array exactly once and performs operations in constant time for each element. Thus, the time complexity is 𝑂
(
𝑛
)
O(n), where
𝑛
n is the number of elements in the array.
Readability:

The code is more straightforward and easier to understand compared to generating combinations. It leverages hash maps for efficient lookups and counting.

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

Tidimatso Anthony and others added 2 commits September 3, 2024 19:02
Dictionary Usage:

We use a dictionary seen to keep track of the number of times each number has appeared so far.
For each number num in the array, we calculate its complement (req_sum - num). If this complement has been seen before, then it means there are pairs that sum up to req_sum, and we add the count of such complements to our count.
Efficiency:

This approach processes each element of the array exactly once and performs operations in constant time for each element. Thus, the time complexity is 
𝑂
(
𝑛
)
O(n), where 
𝑛
n is the number of elements in the array.
Readability:

The code is more straightforward and easier to understand compared to generating combinations. It leverages hash maps for efficient lookups and counting.
@ghost ghost closed this Sep 3, 2024
@ghost ghost reopened this Sep 3, 2024
@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Sep 3, 2024
@ghost ghost closed this by deleting the head repository Sep 3, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This PR modified some existing files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants