Skip to content

Enhance similarity search with flexible distance metrics and k-neares… #11531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Enhance similarity search with flexible distance metrics and k-neares… #11531

wants to merge 2 commits into from

Conversation

OMS1996
Copy link

@OMS1996 OMS1996 commented Aug 28, 2024

Enhance similarity search with flexible distance metrics and k-nearest neighbors

  • Add distance_func parameter to support custom distance metrics
  • Implement k-nearest neighbors search
  • Optimize euclidean distance calculation using NumPy
  • Add cosine distance function as an alternative metric
  • Improve performance with list comprehensions
  • Add type hints for better code readability
  • Include additional examples demonstrating new features

Describe your change:

  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

OMS1996 and others added 2 commits August 27, 2024 22:34
@OMS1996
Enhance similarity search with flexible distance metrics and k-neares…
1898766 
…t neighbors

- Add distance_func parameter to support custom distance metrics
- Implement k-nearest neighbors search
- Optimize euclidean distance calculation using NumPy
- Add cosine distance function as an alternative metric
- Improve performance with list comprehensions
- Add type hints for better code readability
- Include additional examples demonstrating new features
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
d7e56d1 
for more information, see https://pre-commit.ci
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Aug 28, 2024
imSanko
imSanko suggested changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@imSanko imSanko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you describe us, that what are the changes you are putting into this ?

@OMS1996 OMS1996 closed this by deleting the head repository Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imSanko imSanko imSanko requested changes

Assignees
No one assigned
Labels
tests are failing Do not merge until tests pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OMS1996 @imSanko