Skip to content

Update q_fourier_transform.py #11512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 37 additions & 40 deletions quantum/q_fourier_transform.py
Original file line number Diff line number Diff line change
@@ -1,16 +1,3 @@
"""
Build the quantum fourier transform (qft) for a desire
number of quantum bits using Qiskit framework. This
experiment run in IBM Q simulator with 10000 shots.
This circuit can be use as a building block to design
the Shor's algorithm in quantum computing. As well as,
quantum phase estimation among others.
.
References:
https://en.wikipedia.org/wiki/Quantum_Fourier_transform
https://qiskit.org/textbook/ch-algorithms/quantum-fourier-transform.html
"""

import math

import numpy as np
Expand All @@ -20,40 +7,48 @@

def quantum_fourier_transform(number_of_qubits: int = 3) -> qiskit.result.counts.Counts:
"""
# >>> quantum_fourier_transform(2)
# {'00': 2500, '01': 2500, '11': 2500, '10': 2500}
# quantum circuit for number_of_qubits = 3:
┌───┐
qr_0: ──────■──────────────────────■───────┤ H ├─X─
│ ┌───┐ │P(π/2) └───┘ │
qr_1: ──────┼────────■───────┤ H ├─■─────────────┼─
┌───┐ │P(π/4) │P(π/2) └───┘ │
qr_2: ┤ H ├─■────────■───────────────────────────X─
└───┘
cr: 3/═════════════════════════════════════════════
Creates a quantum Fourier transform circuit and simulates it on a quantum simulator.

Args:
n : number of qubits
number_of_qubits (int): The number of qubits in the quantum Fourier transform circuit.

Check failure on line 13 in quantum/q_fourier_transform.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (E501)

quantum/q_fourier_transform.py:13:89: E501 Line too long (94 > 88)

Check failure on line 13 in quantum/q_fourier_transform.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (E501)

quantum/q_fourier_transform.py:13:89: E501 Line too long (94 > 88)

Check failure on line 13 in quantum/q_fourier_transform.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (E501)

quantum/q_fourier_transform.py:13:89: E501 Line too long (94 > 88)

Returns:
qiskit.result.counts.Counts: distribute counts.
qiskit.result.counts.Counts: The counts of the measurement results.

Raises:
TypeError: If number_of_qubits is not an integer.
ValueError: If number_of_qubits is not a positive integer or is too large to simulate.

Check failure on line 20 in quantum/q_fourier_transform.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (E501)

quantum/q_fourier_transform.py:20:89: E501 Line too long (94 > 88)

Check failure on line 20 in quantum/q_fourier_transform.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (E501)

quantum/q_fourier_transform.py:20:89: E501 Line too long (94 > 88)

Check failure on line 20 in quantum/q_fourier_transform.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (E501)

quantum/q_fourier_transform.py:20:89: E501 Line too long (94 > 88)

Examples:
>>> quantum_fourier_transform(2)
{'00': 2500, '01': 2500, '10': 2500, '11': 2500}

>>> quantum_fourier_transform(2)
{'00': 2500, '01': 2500, '10': 2500, '11': 2500}
>>> quantum_fourier_transform(-1)
Traceback (most recent call last):
>>> quantum_fourier_transform(3) # returns a result close to this due to randomness

Check failure on line 26 in quantum/q_fourier_transform.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (E501)

quantum/q_fourier_transform.py:26:89: E501 Line too long (92 > 88)

Check failure on line 26 in quantum/q_fourier_transform.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (E501)

quantum/q_fourier_transform.py:26:89: E501 Line too long (92 > 88)

Check failure on line 26 in quantum/q_fourier_transform.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (E501)

quantum/q_fourier_transform.py:26:89: E501 Line too long (92 > 88)
{'000': 1250, '001': 1250, '010': 1250, '011': 1250, '100': 1250, '101': 1250,
'110': 1250, '111': 1250}

>>> quantum_fourier_transform(1)
{'0': 5000, '1': 5000}

>>> quantum_fourier_transform(-1)
Traceback (most recent call last):
...
ValueError: number of qubits must be > 0.
>>> quantum_fourier_transform('a')
Traceback (most recent call last):
ValueError: number of qubits must be > 0.

>>> quantum_fourier_transform('a')
Traceback (most recent call last):
...
TypeError: number of qubits must be a integer.
>>> quantum_fourier_transform(100)
Traceback (most recent call last):
TypeError: number of qubits must be a integer.

>>> quantum_fourier_transform(100)
Traceback (most recent call last):
...
ValueError: number of qubits too large to simulate(>10).
>>> quantum_fourier_transform(0.5)
Traceback (most recent call last):
ValueError: number of qubits too large to simulate(>10).

>>> quantum_fourier_transform(0.5)
Traceback (most recent call last):
...
ValueError: number of qubits must be exact integer.
ValueError: number of qubits must be exact integer.
"""
if isinstance(number_of_qubits, str):
raise TypeError("number of qubits must be a integer.")
Expand Down Expand Up @@ -90,6 +85,8 @@


if __name__ == "__main__":
import doctest
doctest.testmod()
print(
f"Total count for quantum fourier transform state is: \
{quantum_fourier_transform(3)}"
Expand Down
Loading