Add doctests for trapezoidal_rule.py #11491
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianyizheng02
requested changes
Aug 6, 2024
| while x < (b - h): | ||
| yield x | ||
| x = x + h | ||
| def make_points(a: float, b: float, h: float) -> Iterator[float]: |
There was a problem hiding this comment.
Could we rename these variables for clarity? Rather than single-letter variable names, we could have something like lower_bound, upper_bound, and step_size.
Comment on lines
52
to
54
| h = (boundary[1] - boundary[0]) / steps | ||
| a = boundary[0] | ||
| b = boundary[1] |
There was a problem hiding this comment.
Same as my other comment: let's rename these variables to be more descriptive.
Comment on lines
56
to
60
| y = 0.0 | ||
| y += (h / 2.0) * f(a) | ||
| for i in x_i: | ||
| # print(i) | ||
| y += h * f(i) | ||
| y += (h / 2.0) * f(b) |
There was a problem hiding this comment.
Minor nitpick: we can change 0.0 and 2.0 to just 0 and 2. Python will appropriately cast values to float anyway, so I don't see a need to specify the decimal points.
tianyizheng02
added
awaiting changes
mus1umcelk
approved these changes
Aug 25, 2024
|
Closing awaiting_changes PRs to prepare for Hacktoberfest 2024 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Contributes to #9943
Checklist: