Skip to content

fix: modify the depracated code and add new tests #11465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

fix: modify the depracated code and add new tests #11465

wants to merge 5 commits into from

Conversation

ra230537
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@ra230537 ra230537 requested a review from cclauss as a code owner June 16, 2024 20:33
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Jun 16, 2024
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Jun 16, 2024
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Jun 16, 2024
@cclauss
Copy link
Member

cclauss commented Jun 16, 2024

We write for the current version of Python (currently v3.12) and we have no desire to ignore
ruff rule UP017

@cclauss cclauss closed this Jun 16, 2024
@ra230537 ra230537 deleted the fix/fixes-get-top-billionaries-code branch June 16, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss Awaiting requested review from cclauss cclauss is a code owner

Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ra230537 @cclauss