Skip to content

Update and_gate.py #11366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion boolean_algebra/and_gate.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def and_gate(input_1: int, input_2: int) -> int:
>>> and_gate(1, 1)
1
"""
return int(input_1 and input_2)
return int((input_1, input_2).count(1) == 2)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gate = int((input_1, input_2).count(1) == 2)
return gate

The motivation for the change was not obvious. As it also doesn't make sense to perform so many operations in return, it's better to separate them.



if __name__ == "__main__":
Expand Down