ENH: two algorithms for the convex hull problem of a set of 2d points on a plain #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
maxwell-aladago
commented
Aug 17, 2019
maxwell-aladago
commented
- A naive brute-force algorithm
- A divide-and-conquer algorithm
cclauss
reviewed
Aug 17, 2019
cclauss
reviewed
Aug 17, 2019
| return False | ||
|
|
||
| def __repr__(self): | ||
| return "({}, {})".format(self.x, self.y) |
There was a problem hiding this comment.
Try this one with an f”string” and see if it is more concise.
There was a problem hiding this comment.
But f'strings' don't work with python 2 or?
|
Actually no, forgot to remove them before committing
… On 17 Aug 2019, at 10:29 AM, Christian Clauss ***@***.***> wrote:
@cclauss commented on this pull request.
In divide_and_conquer/convex_hull.py <#1135 (comment)>:
> + True
+ >>> Point(-0.5, 1) == Point(0.5, 1)
+ False
+ >>> Point("pi", "e")
+ Traceback (most recent call last):
+ ...
+ ValueError: x and y must be both numeric types but got <class 'str'>, <class 'str'> instead
+ """
+
+ def __init__(self, x, y):
+ if not (isinstance(x, Number) and isinstance(y, Number)):
+ try:
+ x, y = float(x), float(y)
+ except ValueError as e:
+ e.args = ("x and y must be both numeric types "
+ "but got {}, {} instead".format(str(type(x)), str(type(y))), )
Are the _str() calls required in this context?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#1135?email_source=notifications&email_token=ADXZYMTCWXIPRWTC3F4FAVTQFADOHA5CNFSM4IMPKTC2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCB3RE7I#pullrequestreview-276238973>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADXZYMRF7TRFP2RMZGTCLRLQFADOHANCNFSM4IMPKTCQ>.
|
cclauss
reviewed
Aug 17, 2019
Thanks, I will make the suggested changes soon. |
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
… on a plain (TheAlgorithms#1135) * divide and conquer and brute force algorithms for array-inversions counting * divide and conquer and brute force algorithms for array-inversions counting * divide and conquer and brute force algorithms for array-inversions counting * a naive and divide-and-conquer algorithms for the convex-hull problem * two convex-hull algorithms, a divide-and-conquer and a naive algorithm * two convex-hull algorithms, a divide-and-conquer and a naive algorithm * two convex-hull algorithms, a divide-and-conquer and a naive algorithm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.