Fix Bug: Missing Edge Case for odd_even_transposition_parallel.py #10976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
algorithms-keeper
bot
added
enhancement
|
Hi, can any of the admins merge this pr, if possible✌️ |
Hey @tianyizheng02 can you please review this pr.❤️ |
cclauss
reviewed
Oct 27, 2023
Comment on lines
+33
to
+39
| position, | ||
| value, | ||
| l_send, | ||
| r_send, | ||
| lr_cv, | ||
| rr_cv, | ||
| result_pipe, |
This branch has conflicts that must be resolved
|
|
Closing awaiting_changes PRs to prepare for Hacktoberfest 2024 |
|
Are you mad by chance??
Regards,
Surya Prakash.K
…Sent from my iPhone
On Mon, 30 Sep 2024 at 2:53 PM, Christian Clauss ***@***.***> wrote:
Closed #10976 <#10976>.
—
Reply to this email directly, view it on GitHub
<#10976 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AESSU2VMAELYHTOKBRNG5RLZZEKAZAVCNFSM6AAAAABPC22X3GVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGQ2TENJUGUYTKMY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
Not mad at all. These PRs were closed by automated scripts. Please feel free to try again tomorrow under Hacktoberfest 2024. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
This enhanced code includes fixed bugs pointed out by @RaymondDashWu. The problem with the Algorithm was that it assumed the length of the array to be sorted equal to 10 (check the 1st for loop inside the function oe_process), which is why when @RaymondDashWu tried sorting an array with length 11, the returned sorted array is not as expected. So, I just passed an argument named arr_len which contains the array's length value.
In addition to fixing this bug, this code includes exception handling for user input, and more detailed docstrings. It's now more robust and readable.
Checklist: