Skip to content

added a function to calculate perceived frequency by observer using Doppler Effect #10776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 46 commits into from
Oct 21, 2023
Merged

added a function to calculate perceived frequency by observer using Doppler Effect #10776

merged 46 commits into from
Oct 21, 2023

Conversation

Baron105
Copy link
Contributor

Describe your change:

added a function to calculate perceived frequency by observer using Doppler Effect

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

Baron105 and others added 30 commits October 10, 2023 19:22
@Baron105
avg and mps speed formulae added
1427fe3
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
0608c40 
for more information, see https://pre-commit.ci
@Baron105
avg and mps speed formulae added
7457b25
@Baron105
fixed_spacing
b1ef5a3
@Baron105
.
c957bd7
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
07502c8 
for more information, see https://pre-commit.ci
@Baron105
spacing
ead4f47
@Baron105
.
c18b39d
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
cb006c3 
for more information, see https://pre-commit.ci
@Baron105
ws
ab04734
@Baron105
Merge branch 'master' of https://github.com/Baron105/Python
69487f3
@Baron105
added amicable numbers
6a741dc
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
d13c09d 
for more information, see https://pre-commit.ci
@Baron105
Merge branch 'TheAlgorithms:master' into master
18df9ba
@Baron105
added amicable numbers
63734b9
@Baron105
descriptive
aa5f176
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
9779c1a 
for more information, see https://pre-commit.ci
@Baron105
spacing
aa4d4e8
@Baron105
Merge branch 'master' of https://github.com/Baron105/Python
7bb663f
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
52c2cb8 
for more information, see https://pre-commit.ci
@Baron105
removed
643958b
@Baron105
Merge branch 'master' of https://github.com/Baron105/Python
65f5851
@Baron105
Merge branch 'TheAlgorithms:master' into master
7f14ab9
@Baron105
changed name of file and added code improvements
c05ed7c
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
886fb5d 
for more information, see https://pre-commit.ci
@Baron105
issues fixed due to pi
97b89cd
@Baron105
Merge branch 'master' of https://github.com/Baron105/Python
a1c783a
@Baron105
requested changes added
1c2b7b2
@Baron105
Merge branch 'TheAlgorithms:master' into master
5aa65b8
@Baron105
Merge branch 'TheAlgorithms:master' into doppler
219d973
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 21, 2023
@cclauss cclauss self-assigned this Oct 21, 2023
cclauss
cclauss requested changes Oct 21, 2023
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raising an Exception is the right thing to do.

@algorithms-keeper algorithms-keeper bot added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Oct 21, 2023
@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Oct 21, 2023
@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 21, 2023
@Baron105 Baron105 requested a review from cclauss October 21, 2023 16:12
@cclauss
Update doppler_frequency.py
36909a1 
This is super slick!  Well done.
@cclauss cclauss enabled auto-merge (squash) October 21, 2023 22:21
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 21, 2023
@algorithms-keeper algorithms-keeper bot added the merge conflicts Open a new PR or rebase on the latest commit label Oct 21, 2023
@algorithms-keeper algorithms-keeper bot removed the merge conflicts Open a new PR or rebase on the latest commit label Oct 21, 2023
@cclauss cclauss merged commit d956203 into TheAlgorithms:master Oct 21, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 21, 2023
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@Baron105 @pre-commit-ci
@cclauss @sedatguzelsemme
added a function to calculate perceived frequency by observer using D…
2761bc2 
…oppler Effect (TheAlgorithms#10776)

* avg and mps speed formulae added

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* avg and mps speed formulae added

* fixed_spacing

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* spacing

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* ws

* added amicable numbers

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* added amicable numbers

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* spacing

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* removed

* changed name of file and added code improvements

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* issues fixed due to pi

* requested changes added

* Created doppler_effect_of_sound.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Updated doppler_effect_of_sound.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* added desc names

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fixed spacing

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* renamed doppler_effect_of_sound.py to doppler_frequency.py

* used expection handling rather than print statements

* fixed spacing for ruff

* Update doppler_frequency.py

This is super slick!  Well done.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Christian Clauss <[email protected]>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees

@cclauss cclauss

Labels
tests are failing Do not merge until tests pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Baron105 @cclauss