-
-
Notifications
You must be signed in to change notification settings - Fork 46.6k
add monotonic queue algorithm #10531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
from __future__ import annotations | ||
|
||
from .double_ended_queue import Deque | ||
|
||
arr = [1, 3, -1, -3, 5, 3, 6, 7] | ||
window_size = 3 | ||
expect = [3, 3, 5, 5, 6, 7] | ||
|
||
|
||
def max_sliding_window(arr: list[float], window_size: int) -> list[float]: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we take the same approach with this algorithm? Seems appropriate for a sliding_window algorithm. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is a bit different because the queue has to be monotonically decreasing while calculating the max value in a window. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If it does not make sense then we can close the pull request. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hi, I resolved the issue of using collections.deque instead of double_ended_queue. I feel the max sliding window is still an important algorithm which is a good use case of the queue (it is similar to next_greater_element in stack). There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @tianyizheng02 Is my iterator, not list request above unreasonable in this algorithm? |
||
""" | ||
Given an array of integers nums, there is a sliding window of size k which is moving | ||
from the very left of the array to the very right. | ||
Each time the sliding window of length window_size moves right by one position. | ||
Return the max sliding window. | ||
>>> max_sliding_window(arr, window_size) == expect | ||
True | ||
""" | ||
max_val = [] | ||
queue = Deque() | ||
for i in range(len(arr)): | ||
# pop the element if the index is outside the window size k | ||
if queue and i - queue._front.val >= window_size: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Using the private
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes! I use the collections.deque now |
||
queue.popleft() | ||
# keep the queue monotonically decreasing | ||
# so that the max value is always on the top | ||
while queue and arr[i] >= arr[queue._back.val]: | ||
queue.pop() | ||
queue.append(i) | ||
# the maximum value is the first element in queue | ||
if i >= window_size - 1: | ||
max_val.append(arr[queue._front.val]) | ||
return max_val | ||
|
||
|
||
if __name__ == "__main__": | ||
from doctest import testmod | ||
|
||
testmod() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this use https://docs.python.org/3/library/collections.html#collections.deque or is there a special capability in the local version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes we can. And so that we can avoid using private attributes