Travis CI: Add pytest --doctest-modules file_transfer_protocol #1044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
changed the title
cclauss
force-pushed
the
Fix-ftp-to-allow-doctests
branch
from
b106097 to
bb458f6
Compare
cclauss
changed the title
AlexDvorak
approved these changes
Jul 20, 2019
| conn.close() | ||
|
|
||
|
|
||
| # client side server |
There was a problem hiding this comment.
Shouldn't the client side server be split into a separate file?
There was a problem hiding this comment.
given the loop above, this should be in a separate file
| s.send("Hello server!") | ||
|
|
||
| with open('received_file', 'wb') as f: | ||
| print('file opened') | ||
| while True: |
There was a problem hiding this comment.
This loop never exits, thus the client side server below never runs.
|
@AlexDvorak I agree. This PR was just trying to get the pytests to run across the entire repo. Please create a separate pull request that deals with all of the issues that you have raised. I will gladly review that PR when it passes our Travis CI tests and then close this PR in favor of yours |
|
@AlexDvorak Your thoughts on progressing this in a separate PR? |
|
That sounds good, I should have the PR open by tomorrow.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #983 The two Python files in the file_transfer_protocol directory currently fail the Travis CI pytests. This pull request makes the changes necessary for Travis CI to run pytest on these files without hanging.