-
-
Notifications
You must be signed in to change notification settings - Fork 46.6k
Adds exponential moving average algorithm #10273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
a33bc05
acdc0a2
1ce781f
7b09aeb
040379f
6edf6e5
68c4bb8
ce8ecce
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,75 @@ | ||||||
""" | ||||||
Calculates exponential moving average (EMA) on the series of numbers | ||||||
Wikipedia Reference: https://en.wikipedia.org/wiki/Exponential_smoothing | ||||||
Reference: https://www.investopedia.com/terms/e/ema.asp#toc-what-is-an-exponential-moving-average-ema | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Lines of Python code should be max 88 characters so let's not overdo it.
Suggested change
|
||||||
|
||||||
Exponential moving average is used in finance to analyze changes stock prices. | ||||||
EMA is used in conjunction with Simple moving average (SMA), EMA reacts to the | ||||||
changes in the value quicker than SMA, which is one of the advantages of using EMA. | ||||||
""" | ||||||
|
||||||
from collections.abc import Iterator | ||||||
|
||||||
|
||||||
def exponential_moving_average( | ||||||
series_generator: Iterator[float], window_size: int | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just plain
Suggested change
|
||||||
) -> Iterator[float]: | ||||||
""" | ||||||
Returns the generator which generates exponential moving average of the given | ||||||
series generator | ||||||
>>> list(exponential_moving_average((ele for ele in [2, 5, 3, 8.2, 6, 9, 10]), 3)) | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just easier to read...
Suggested change
|
||||||
[2.0, 3.5, 3.25, 5.725, 5.8625, 7.43125, 8.715625] | ||||||
|
||||||
:param series_generator: Generator which generates numbers | ||||||
:param window_size: Window size for calculating average (window_size > 0) | ||||||
:return: Returns generator of which returns exponentially averaged numbers | ||||||
|
||||||
Formula: | ||||||
|
||||||
st = alpha * xt + (1 - alpha) * st_prev | ||||||
cclauss marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
alpha = 2/(1 + window_size) - smoothing factor | ||||||
|
||||||
Exponential moving average (EMA) is a rule of thumb technique for | ||||||
smoothing time series data using the exponential window function. | ||||||
""" | ||||||
|
||||||
if window_size <= 0: | ||||||
raise ValueError("window_size must be > 0") | ||||||
|
||||||
# Calculating smoothing factor | ||||||
alpha = 2 / (1 + window_size) | ||||||
|
||||||
# Defining timestamp t | ||||||
t = 0 | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Or maybe even better, |
||||||
|
||||||
# Exponential average at timestamp t | ||||||
st = None | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks! |
||||||
|
||||||
for xt in series_generator: | ||||||
if t <= window_size: | ||||||
# Assigning simple moving average till the window_size for the first time | ||||||
# is reached | ||||||
st = float(xt) if st is None else (st + xt) * 0.5 | ||||||
else: | ||||||
# Calculating exponential moving average based on current timestamp data | ||||||
# point and previous exponential average value | ||||||
st = (alpha * xt) + ((1 - alpha) * st) | ||||||
t += 1 | ||||||
yield st | ||||||
|
||||||
|
||||||
if __name__ == "__main__": | ||||||
import doctest | ||||||
|
||||||
doctest.testmod() | ||||||
|
||||||
def test_gen_func(arr: list[float]): | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As there is no test file in this pull request nor any test function or class in the file Please provide return type hint for the function: |
||||||
yield from arr | ||||||
|
||||||
test_series = [2, 5, 3, 8.2, 6, 9, 10] | ||||||
cclauss marked this conversation as resolved.
Show resolved
Hide resolved
cclauss marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
test_generator = test_gen_func(test_series) | ||||||
test_window_size = 3 | ||||||
result = exponential_moving_average(test_generator, test_window_size) | ||||||
print("Test series: ", test_series) | ||||||
print("Window size: ", test_window_size) | ||||||
print("Result: ", list(result)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Active tense