Skip to content

rotate_matrix.py: Add type hints for return values #1023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 22, 2019
Merged

rotate_matrix.py: Add type hints for return values #1023

merged 8 commits into from
Jul 22, 2019

Conversation

cclauss
Copy link
Member

@cclauss cclauss commented Jul 15, 2019

@obelisk0114 Your review please?

obelisk0114
obelisk0114 suggested changes Jul 15, 2019
View reviewed changes
@obelisk0114
Copy link
Contributor

obelisk0114 commented Jul 15, 2019 •
edited
Loading

All codes are correct.
(Optional) You can add transpose(reverse_column(matrix)) under def rotate_90(matrix: [[]]) -> [[]]:

@cclauss
Copy link
Member Author

cclauss commented Jul 16, 2019

Added utility function make_matrix().

@cclauss
Copy link
Member Author

cclauss commented Jul 16, 2019

@brunohadlich Your review please?

@cclauss cclauss added the awaiting reviews This PR is ready to be reviewed label Jul 16, 2019
@cclauss
Copy link
Member Author

cclauss commented Jul 21, 2019 •
edited
Loading

@obelisk0114 Can I please get you to re-review after the modifications?

poyea
poyea approved these changes Jul 22, 2019
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I don't know if there will be warning.

@cclauss cclauss merged commit b2ed8d4 into master Jul 22, 2019
@cclauss cclauss deleted the Add-type-hints-for-return-values branch July 22, 2019 22:07
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@cclauss @stokhos
rotate_matrix.py: Add type hints for return values (TheAlgorithms#1023)
c3c550e 
* rotate_matrix.py: Add type hints for return values

@obelisk0114 Your review please?

* Fix typo

* Run the code thru python/black

https://github.com/python/black

* Fix 270 comment

* Simplify with get_data() and test the alternatives

* ) * 3

* Update rotate_matrix.py

* Update rotate_matrix.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obelisk0114 obelisk0114 obelisk0114 approved these changes

@poyea poyea poyea approved these changes

@AnshulMalik AnshulMalik Awaiting requested review from AnshulMalik

@AnupKumarPanwar AnupKumarPanwar Awaiting requested review from AnupKumarPanwar

@ParthS007 ParthS007 Awaiting requested review from ParthS007

Assignees

@obelisk0114 obelisk0114

Labels
awaiting reviews This PR is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cclauss @obelisk0114 @poyea