Skip to content

Changes the code To return the list in dynamic_programming/subset_generation.py #10191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Oct 15, 2023
Merged

Changes the code To return the list in dynamic_programming/subset_generation.py #10191

merged 27 commits into from
Oct 15, 2023

Conversation

AasheeshLikePanner
Copy link
Contributor

Describe your change:

Changes the code to return the tuples. So, we can add doctests in it after it. Change the whole code now code using dynamic programming as it header says

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".
    Change Code to return tuple in dynamic_programming/subset_generation.py #10189

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 9, 2023
@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 9, 2023
@AasheeshLikePanner AasheeshLikePanner mentioned this pull request Oct 15, 2023
Closed
@cclauss cclauss self-assigned this Oct 15, 2023
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 15, 2023
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 15, 2023
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 15, 2023
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 15, 2023
cclauss
cclauss reviewed Oct 15, 2023
View reviewed changes
dynamic_programming/subset_generation.py Outdated
arr = [10, 20, 30, 40, 50]
print_combination(arr, len(arr), 3)
# This code is contributed by Ambuj sahu
print(f"{subset_combinations_dp(elements=[10, 20, 30, 40], n=2) = }")
Copy link
Member

@cclauss cclauss Oct 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

subset_combinations_dp() should work the same way as itertools.combinations(). It should present the same sort order and raise the same exceptions.

Suggested change
print(f"{subset_combinations_dp(elements=[10, 20, 30, 40], n=2) = }")
from itertools import combinations
for items, n in (
([10, 20, 30, 40], 2), ([1, 2, 3], 1), ([1, 2, 3], 3), ([42], 1),
([6, 7, 8, 9], 4), ([10, 20, 30, 40, 50], 1), ([1, 2, 3, 4], 2),
([1, 'apple', 3.14], 2), (['single'], 0), ([], 9)
):
actual = subset_combinations_dp(items, n)
expected = list(combinations(items, n))
assert actual == expected, f"items, n: {actual} != {expected}"
print(f"{subset_combinations_dp(elements=[10, 20, 30, 40], n=2) = }")

Copy link
Contributor Author

@AasheeshLikePanner AasheeshLikePanner Oct 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed the code now code giving the list sorted order

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

itertools.combinations([1, 'apple', 3.14], 2)

@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 15, 2023
cclauss
cclauss approved these changes Oct 15, 2023
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for going the extra mile on this one... It is a nice upgrade!

@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 15, 2023
@cclauss cclauss merged commit 902278f into TheAlgorithms:master Oct 15, 2023
@AasheeshLikePanner
Copy link
Contributor Author

Really challenging and enjoyable. I fix one bug, then two errors comes. It's kind of frustrating, but worth the time.

@cclauss
Copy link
Member

cclauss commented Oct 16, 2023

I fix one bug, then two errors comes. It's kind of frustrating, but worth the time.

Sounds like software engineering to me. ;-)

@cclauss cclauss mentioned this pull request Oct 17, 2023
Closed
14 tasks
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@AasheeshLikePanner @pre-commit-ci
@cclauss @sedatguzelsemme
Changes the code To return the list in dynamic_programming/subset_gen…
cafd9c3 
…eration.py (TheAlgorithms#10191)

* Changing the code to return tuple

* Changing the code to return tuple

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update dynamic_programming/subset_generation.py

Co-authored-by: Christian Clauss <[email protected]>

* Adding doctests in subset_generation.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update subset_generation.py

* Update subset_generation.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update subset_generation.py

* Update subset_generation.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update dynamic_programming/subset_generation.py

Co-authored-by: Christian Clauss <[email protected]>

* Update stock_span_problem.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update subset_generation.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update subset_generation.py

* Update subset_generation.py

* Update subset_generation.py

* Update subset_generation.py

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Christian Clauss <[email protected]>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees

@cclauss cclauss

Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AasheeshLikePanner @cclauss