#9611 serialize and deserialize #10128
Conversation
algorithms-keeper
bot
added
require descriptive names
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| Returns : Creates new object of Node. | ||
| """ | ||
| class Node: | ||
| def __init__(self, x: int): |
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide descriptive name for the parameter: x
| self.left = None | ||
| self.right = None | ||
|
|
||
| def make_tree() -> Node | None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/serialize_and_deserialize_binary_tree.py, please provide doctest for the function make_tree
| Returns : A string of preorder traversal of nodes in a tree along with null values of leaf nodes. | ||
| """ | ||
|
|
||
| def serialize(root: Node | None) -> str | None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/serialize_and_deserialize_binary_tree.py, please provide doctest for the function serialize
|
|
||
| def serialize(root: Node | None) -> str | None: | ||
| result = [] | ||
| def depth_first_search(node): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/serialize_and_deserialize_binary_tree.py, please provide doctest for the function depth_first_search
Please provide return type hint for the function: depth_first_search. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: node
| Returns : Root of the tree created after deserialing the string. | ||
| """ | ||
|
|
||
| def deserialize(data: str | None) -> Node | None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/serialize_and_deserialize_binary_tree.py, please provide doctest for the function deserialize
| global index | ||
| index = 0 | ||
| node_values = data.split(",") | ||
| def depth_first_search(): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/serialize_and_deserialize_binary_tree.py, please provide doctest for the function depth_first_search
Please provide return type hint for the function: depth_first_search. If the function does not return a value, please provide the type hint as: def function() -> None:
| return depth_first_search() | ||
|
|
||
| #This method is written to traverse the tree created by deserialize method. | ||
| def preorder(root: Node | None) -> Generator[int, None, None]: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/serialize_and_deserialize_binary_tree.py, please provide doctest for the function preorder
| yield from preorder(root.left) | ||
| yield from preorder(root.right) | ||
|
|
||
| def main() -> None: # Main function for testing. |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/serialize_and_deserialize_binary_tree.py, please provide doctest for the function main
for more information, see https://pre-commit.ci
algorithms-keeper
bot
removed
the
require descriptive names
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| self.left = None | ||
| self.right = None | ||
|
|
||
| def make_tree() -> Node | None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/serialize_and_deserialize_binary_tree.py, please provide doctest for the function make_tree
| '20,2,N,N,13,4,N,N,5,N,N' | ||
| """ | ||
| result = [] | ||
| def depth_first_search(node)-> Node | None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/serialize_and_deserialize_binary_tree.py, please provide doctest for the function depth_first_search
Please provide type hint for the parameter: node
| global index | ||
| index = 0 | ||
| node_values = data.split(",") | ||
| def depth_first_search() -> Node | None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/serialize_and_deserialize_binary_tree.py, please provide doctest for the function depth_first_search
| yield from preorder(root.left) | ||
| yield from preorder(root.right) | ||
|
|
||
| def main() -> None: # Main function for testing. |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/serialize_and_deserialize_binary_tree.py, please provide doctest for the function main
for more information, see https://pre-commit.ci
algorithms-keeper
bot
removed
the
require type hints
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| self.left = None | ||
| self.right = None | ||
|
|
||
| def make_tree() -> Node: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/serialize_and_deserialize_binary_tree.py, please provide doctest for the function make_tree
| '20,2,N,N,13,4,N,N,5,N,N' | ||
| """ | ||
| result = [] | ||
| def depth_first_search(node: Node)-> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/serialize_and_deserialize_binary_tree.py, please provide doctest for the function depth_first_search
| global index | ||
| index = 0 | ||
| node_values = data.split(",") | ||
| def depth_first_search() -> Node | None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/serialize_and_deserialize_binary_tree.py, please provide doctest for the function depth_first_search
| yield from preorder(root.left) | ||
| yield from preorder(root.right) | ||
|
|
||
| def main() -> None: # Main function for testing. |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/serialize_and_deserialize_binary_tree.py, please provide doctest for the function main
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| self.left : Node | None = None | ||
| self.right : Node | None = None | ||
|
|
||
| def make_tree() -> Node: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/serialize_and_deserialize_binary_tree.py, please provide doctest for the function make_tree
| '20,2,N,N,13,4,N,N,5,N,N' | ||
| """ | ||
| result = [] | ||
| def depth_first_search(node: Node)-> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/serialize_and_deserialize_binary_tree.py, please provide doctest for the function depth_first_search
| global index | ||
| index = 0 | ||
| node_values = data.split(",") | ||
| def depth_first_search() -> Node | None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/serialize_and_deserialize_binary_tree.py, please provide doctest for the function depth_first_search
| yield from preorder(root.left) | ||
| yield from preorder(root.right) | ||
|
|
||
| def main() -> None: # Main function for testing. |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/serialize_and_deserialize_binary_tree.py, please provide doctest for the function main
for more information, see https://pre-commit.ci
|
Closing require_tests PRs to prepare for Hacktoberfest 2024 |
Describe your change:
Added Algorithm : Serialize and Deserialize a Binary Tree #9611
Checklist: