Feature/stack using two queues #10086
Conversation
algorithms-keeper
bot
added
enhancement
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| @@ -0,0 +1,64 @@ | |||
| class StackUsingQueues: | |||
| def __init__(self): | |||
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
| self.queue1 = [] | ||
| self.queue2 = [] | ||
|
|
||
| def push(self,item): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/stacks/TwoQueuedStack.py, please provide doctest for the function push
Please provide return type hint for the function: push. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: item
|
|
||
|
|
||
|
|
||
| def pop(self): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/stacks/TwoQueuedStack.py, please provide doctest for the function pop
Please provide return type hint for the function: pop. If the function does not return a value, please provide the type hint as: def function() -> None:
|
|
||
|
|
||
|
|
||
| def peek(self): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/stacks/TwoQueuedStack.py, please provide doctest for the function peek
Please provide return type hint for the function: peek. If the function does not return a value, please provide the type hint as: def function() -> None:
for more information, see https://pre-commit.ci
algorithms-keeper
bot
removed
the
require tests
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| self.queue1 = [] | ||
| self.queue2 = [] | ||
|
|
||
| def push(self, item) -> None: |
There was a problem hiding this comment.
Please provide type hint for the parameter: item
for more information, see https://pre-commit.ci
…ouhardyo/Python_TheAlgorithms into feature/StackUsingTwoQueues
algorithms-keeper
bot
removed
the
require type hints
for more information, see https://pre-commit.ci
Describe your change:
I have created a class to implement the Stack Data Structure using Two Queues.
Fixes #9987
Checklist: