-
-
Notifications
You must be signed in to change notification settings - Fork 46.6k
Fix/generate parentheses iterative #10023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Pr0-C0der
wants to merge
2
commits into
TheAlgorithms:master
from
Pr0-C0der:fix/generate_parentheses_iterative
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
""" | ||
Generate all valid combinations of parentheses (Iterative Approach). | ||
|
||
The algorithm works as follows: | ||
1. Initialize an empty list to store the combinations. | ||
2. Initialize a stack to keep track of partial combinations. | ||
3. Start with empty string and push it onstack along with the counts of '(' and ')'. | ||
|
||
4. While the stack is not empty: | ||
a. Pop a partial combination and its open and close counts from the stack. | ||
b. If the combination length is equal to 2*n, add it to the result. | ||
c. If open count is < n, push new combination with added '(' onto the stack. | ||
d. If close count < open count, push new combination with added ')' on stack. | ||
5. Return the result containing all valid combinations. | ||
|
||
Args: | ||
n (int): The desired length of the parentheses combinations | ||
|
||
Returns: | ||
list: A list of strings representing valid combinations of parentheses | ||
|
||
Time Complexity: | ||
O(2^(2n)) | ||
|
||
Space Complexity: | ||
O(2^(2n)) | ||
""" | ||
|
||
|
||
def generate_parentheses(n: int) -> list: | ||
""" | ||
>>> generate_parentheses(3) | ||
['()()()', '()(())', '(())()', '(()())', '((()))'] | ||
|
||
>>> generate_parentheses(2) | ||
['()()', '(())'] | ||
|
||
>>> generate_parentheses(1) | ||
['()'] | ||
|
||
>>> generate_parentheses(0) | ||
[''] | ||
|
||
""" | ||
result = [] | ||
stack = [] | ||
|
||
# Each element in stack has a tuple (current_combination, open_count, close_count). | ||
stack.append(("", 0, 0)) | ||
|
||
while stack: | ||
current_combination, open_count, close_count = stack.pop() | ||
|
||
if len(current_combination) == 2 * n: | ||
result.append(current_combination) | ||
else: | ||
if open_count < n: | ||
stack.append((current_combination + "(", open_count + 1, close_count)) | ||
if close_count < open_count: | ||
stack.append((current_combination + ")", open_count, close_count + 1)) | ||
|
||
return result | ||
|
||
|
||
def main() -> None: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As there is no test file in this pull request nor any test function or class in the file |
||
print(generate_parentheses(4)) | ||
|
||
|
||
if __name__ == "__main__": | ||
import doctest | ||
|
||
doctest.testmod() | ||
main() |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide descriptive name for the parameter:
n