Skip to content

I found typo in graphs/greedy_best_first #8764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JadeKim042386 opened this issue May 24, 2023 · 0 comments · Fixed by #8766
Closed

I found typo in graphs/greedy_best_first #8764

JadeKim042386 opened this issue May 24, 2023 · 0 comments · Fixed by #8766
Labels
awaiting triage Awaiting triage from a maintainer

Comments

@JadeKim042386
Copy link
Contributor

What would you like to share?

The dx and dy are reversed!

Python/graphs/greedy_best_first.py

Lines 61 to 63 in ce43a8a

dy = abs(self.pos_x - self.goal_x)
dx = abs(self.pos_y - self.goal_y)
return dx + dy

Expected correction

dx = abs(self.pos_x - self.goal_x)
dy = abs(self.pos_y - self.goal_y)
return dx + dy

Additional information

No response
@JadeKim042386 JadeKim042386 added the awaiting triage Awaiting triage from a maintainer label May 24, 2023
@JadeKim042386 JadeKim042386 mentioned this issue May 24, 2023
Closed
14 tasks
JadeKim042386 added a commit to JadeKim042386/Python that referenced this issue May 24, 2023
@JadeKim042386
fix: graphs/greedy_best_first typo
c27ed0c 
TheAlgorithms#8764
JadeKim042386 added a commit to JadeKim042386/Python that referenced this issue May 25, 2023
@JadeKim042386
fix: graphs/greedy_best_first typo
3d1174c 
TheAlgorithms#8764
@JadeKim042386 JadeKim042386 mentioned this issue May 25, 2023
Merged
14 tasks
JadeKim042386 added a commit to JadeKim042386/Python that referenced this issue May 25, 2023
@JadeKim042386
fix: graphs/greedy_best_first typo
198113c 
TheAlgorithms#8764
@cclauss cclauss closed this as completed May 25, 2023
cclauss pushed a commit that referenced this issue May 25, 2023
@JadeKim042386
fix: graphs/greedy_best_first typo (#8766)
a17791d 
#8764
tianyizheng02 pushed a commit to tianyizheng02/Python that referenced this issue May 29, 2023
@JadeKim042386 @tianyizheng02
fix: graphs/greedy_best_first typo (TheAlgorithms#8766)
7333b51 
TheAlgorithms#8764
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this issue Sep 15, 2024
@JadeKim042386 @sedatguzelsemme
fix: graphs/greedy_best_first typo (TheAlgorithms#8766)
8d9173b 
TheAlgorithms#8764
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
awaiting triage Awaiting triage from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix typo graphs/greedy_best_first.py JadeKim042386/Python
2 participants
@cclauss @JadeKim042386