Skip to content

Suggestion / opinion needed: Add a line in the boolean_algebra/and_gate.py file #8632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
EngineerMarek opened this issue Apr 10, 2023 · 2 comments
Labels
awaiting triage Awaiting triage from a maintainer

Comments

@EngineerMarek
Copy link

What would you like to share?

I want to suggest adding a line in the boolean_algebra/and_gate.py file and want to see what others think.

if __name__ == "__main__":
    print(and_gate(0, 0))
    print(and_gate(0, 1))
    print(and_gate(1, 1))

This is an excerpt from lines 45 - 48.

I want to suggest changing it to this:

if __name__ == "__main__":
    print(and_gate(0, 0))
    print(and_gate(0, 1))
    print(and_gate(1, 0))
    print(and_gate(1, 1))

adding print(and_gate(1, 0)) completes all examples, and with the others being there, I don't see a reason why we shouldn't have that line also, especially because it is present in the tests. What do you guys think?

Additional information

No response

@EngineerMarek EngineerMarek added the awaiting triage Awaiting triage from a maintainer label Apr 10, 2023
rohan472000 added a commit to rohan472000/Python that referenced this issue Apr 24, 2023
@rohan472000
Copy link
Contributor

@EngineerMarek , kindly check PR #8690 .

ChrisO345 pushed a commit that referenced this issue May 10, 2023
* Update and_gate.py

addressing issue #8656 by calling `test_and_gate()` , ensuring that all the assertions are verified before the actual output is printed.

* Update and_gate.py

addressing issue #8632
@tianyizheng02
Copy link
Contributor

@ChrisO345 it should be good to close this now

tianyizheng02 pushed a commit to tianyizheng02/Python that referenced this issue May 29, 2023
* Update and_gate.py

addressing issue TheAlgorithms#8656 by calling `test_and_gate()` , ensuring that all the assertions are verified before the actual output is printed.

* Update and_gate.py

addressing issue TheAlgorithms#8632
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this issue Sep 15, 2024
* Update and_gate.py

addressing issue TheAlgorithms#8656 by calling `test_and_gate()` , ensuring that all the assertions are verified before the actual output is printed.

* Update and_gate.py

addressing issue TheAlgorithms#8632
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting triage Awaiting triage from a maintainer
Projects
None yet
Development

No branches or pull requests

4 participants