Skip to content

Merge duplicate implementations of Maximum Subarray Sum #8609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tianyizheng02 opened this issue Apr 3, 2023 · 3 comments
Closed

Merge duplicate implementations of Maximum Subarray Sum #8609

tianyizheng02 opened this issue Apr 3, 2023 · 3 comments
Labels
enhancement This PR modified some existing files

Comments

@tianyizheng02
Copy link
Contributor

Feature description

There are multiple code files in this repo that all solve the maximum subarray sum problem, some of which are more or less duplicates. For example, these two files both implement a divide-and-conquer solution:

And I think these two both implement a sliding-window solution:

There may even be more implementations that I missed. At the very least, duplicates should be merged into a single file.

@tianyizheng02 tianyizheng02 added the enhancement This PR modified some existing files label Apr 3, 2023
@ankit-gautam23
Copy link

Is this still open? I would like to look into it.

snehanjaligvs added a commit to snehanjaligvs/Python that referenced this issue Apr 11, 2023
Merge duplicate implementations of Maximum Subarray Sum TheAlgorithms#8609
snehanjaligvs added a commit to snehanjaligvs/Python that referenced this issue Apr 11, 2023
Merge duplicate implementations of Maximum Subarray Sum TheAlgorithms#8609
snehanjaligvs added a commit to snehanjaligvs/Python that referenced this issue Apr 11, 2023
Merge duplicate implementations of Maximum Subarray Sum TheAlgorithms#8609
snehanjaligvs added a commit to snehanjaligvs/Python that referenced this issue Apr 11, 2023
Merge duplicate implementations of Maximum Subarray Sum TheAlgorithms#8609
snehanjaligvs added a commit to snehanjaligvs/Python that referenced this issue Apr 11, 2023
Merge duplicate implementations of Maximum Subarray Sum TheAlgorithms#8609
snehanjaligvs added a commit to snehanjaligvs/Python that referenced this issue Apr 11, 2023
Merge duplicate implementations of Maximum Subarray Sum TheAlgorithms#8609
snehanjaligvs added a commit to snehanjaligvs/Python that referenced this issue Apr 11, 2023
@snehanjaligvs
Copy link

@tianyizheng02 I have implemented a dynamic programming solution in the dynamic_programming/max_sub_array.py file and
also opened a pull request regarding this.
I have not done anything about the sliding window solutions.

@tianyizheng02
Copy link
Contributor Author

Closing in favor of #8812 (didn't realize I opened a duplicate issue). Keeping the newer one because I list out the duplicates more comprehensively there.

@tianyizheng02 tianyizheng02 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This PR modified some existing files
Projects
None yet
Development

No branches or pull requests

3 participants