Skip to content

Python/Graphs/floyd_warshall.py #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AkashAli506 opened this issue Mar 2, 2019 · 2 comments
Closed

Python/Graphs/floyd_warshall.py #727

AkashAli506 opened this issue Mar 2, 2019 · 2 comments

Comments

@AkashAli506
Copy link
Contributor

Proper comments should need to be added in "Python/Graphs/floyd_warshall.py" file for better understanding.
@axelfj
Copy link

axelfj commented May 2, 2019

Make a code review inside the changes! It's better if you let them know what info you want in the .py

@StephenGemin StephenGemin mentioned this issue Jun 10, 2019
Merged
poyea pushed a commit that referenced this issue Jun 18, 2019
@StephenGemin @poyea
Add docstring and comments per Issue #727 (#895)
a99acae 
I've added comments to make understanding this method a little easier for those that are not familiar.  This should close out #727 .

Other changes:
1. added if __name__ == '__main__' rather than the "# MAIN" comment
2. put in return for distances and vertices.  Previously everything was just printed out, but someone may find it useful to have the algorithm return something.
3. Other PEP8 changes
4.  Added example input and expected output as a check to make sure any future changes will give the same output.
@github-actions
Copy link

github-actions bot commented Dec 4, 2019

Stale issue message

@cclauss cclauss closed this as completed Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cclauss @axelfj @AkashAli506