Skip to content

Project euler problem 104 broken #7069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
CaedenPH opened this issue Oct 12, 2022 · 11 comments
Closed
1 task done

Project euler problem 104 broken #7069

CaedenPH opened this issue Oct 12, 2022 · 11 comments
Labels
invalid

Comments

@CaedenPH
Copy link
Contributor

Feature description

Disable project euler problem 104

Would you like to work on this feature?

  • Yes, I want to work on this feature!
@CaedenPH CaedenPH added the enhancement This PR modified some existing files label Oct 12, 2022
cclauss added a commit that referenced this issue Oct 12, 2022
@CaedenPH @cclauss @pre-commit-ci
Add pep8-naming to pre-commit hooks and fixes incorrect naming conven…
07e991d 
…tions (#7062)

* ci(pre-commit): Add pep8-naming to `pre-commit` hooks (#7038)

* refactor: Fix naming conventions (#7038)

* Update arithmetic_analysis/lu_decomposition.py

Co-authored-by: Christian Clauss <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* refactor(lu_decomposition): Replace `NDArray` with `ArrayLike` (#7038)

* chore: Fix naming conventions in doctests (#7038)

* fix: Temporarily disable project euler problem 104 (#7069)

* chore: Fix naming conventions in doctests (#7038)

Co-authored-by: Christian Clauss <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@AnishJoshi13
Copy link

I would like to work on this issue. Please assign it to me

@cclauss
Copy link
Member

cclauss commented Oct 13, 2022

There is no assigning in this repository. If you can fix it then please create a pull request. If you and someone else both create pull requests then we can review them both and select the best one. Waiting to be assigned it a waste of time.

@dhruvmanila
Copy link
Member

@cclauss should the bot/workflow add a comment similar to what you just mentioned every time an issue is opened? I see people keep on asking to be assigned.

@dhruvmanila
Copy link
Member

Also, @CaedenPH this seems like a bug, please use the bug template.

@dhruvmanila dhruvmanila closed this as not planned Won't fix, can't repro, duplicate, stale Oct 14, 2022
@dhruvmanila dhruvmanila added invalid and removed enhancement This PR modified some existing files labels Oct 14, 2022
@CaedenPH
Copy link
Contributor Author

@dhruvmanila
The problem with the bug report template is that it wants python version and dependencies version for a problem that is just clearly broken. The checks have failed on it and therefore it has the .FIXME extension. This is technically a feature request because the bug has been fixed and now it's just a feature to either rewrite it or fix it

@CaedenPH
Copy link
Contributor Author

This is why I suggested #7012

@cclauss
Copy link
Member

cclauss commented Oct 14, 2022

should the bot/workflow add a comment

Yes please! People waiting to be assigned drives me nuts!

@CaedenPH
Copy link
Contributor Author

should the bot/workflow add a comment

Yes please! People waiting to be assigned drives me nuts!

I thought most of the people commenting that are hacktoberfest bots?

@cclauss
Copy link
Member

cclauss commented Oct 15, 2022

I am all for having our bot confuse their bot ;-)

@dhruvmanila
Copy link
Member

The problem with the bug report template is that it wants python version and dependencies version for a problem that is just clearly broken.

If you would look closely, you'll realize that the Python version does matter when reproducing the bug as this is the cause of the error: https://docs.python.org/3/whatsnew/3.10.html#notable-security-feature-in-3-10-7 which was introduced in Python 3.10.7

The checks have failed on it and therefore it has the .FIXME extension. This is technically a feature request because the bug has been fixed and now it's just a feature to either rewrite it or fix it

By adding a random extension, the problem is just postponed and not fixed. So, this is not a feature request, but a bug which needs to be fixed as per the latest fixes in the language itself.

@cclauss
Copy link
Member

cclauss commented Oct 15, 2022

As long as there is an issue opened to fix the disabling, I see no problem as long as there is significant value in disabling.

I asked @CaedenPH to disable one algorithm in this way and open a new issue to get it fixed. This one algorithm was blocking a PR that @CaedenPH was working on that had 100+ files modified. These kind of pull requests quickly raise conflicts on busy repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
invalid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cclauss @CaedenPH @dhruvmanila @AnishJoshi13