Can we add flake8, mypy and python black to this checklist ?

[QuantumNovice]

Most pull requests have pre-commit checks failing because the author haven't used it.

[poyea]

Doable. I suggest perhaps we can change some items to flake8, mypy and black. e.g. type hints <-> mypy

[AbhijithGanesh]

Would that mean addition of the packages to GitHub Actions ? If it is used for checking the code pushed in via PRs, can I work on it?

[poyea]

We already have it in place. Now we need to make it clearer in the list of our PR template.

[AbhijithGanesh]

No, my question is, can we implement this through GH Actions which would enforce pep8 standards or fail the tests.

[poyea]

@AbhijithGanesh We've it here.

[AbhijithGanesh]

got it.

[joesinghh]

Doable. I suggest perhaps we can change some items to flake8, mypy and black. e.g. type hints <-> mypy

do you mean changing type hint to mypy? like this?

• All function parameters and return values are annotated with Python mypy.

I'm confused about how should I add black and flake8.

[joesinghh]

• Modified code follows black code style.
  @poyea could you tell me how can I add flake8 ?

[ren276]

its doable bro

[cclauss]

Not needed as discussed in #4797

The more stuff that we ask contributors to fill out, the less likely that they will do so.

[joesinghh]

point.