Skip to content

Update CONTRIBUTING.md Regarding Validate filenames Fail #12352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kangaroo-eating-carrots opened this issue Nov 6, 2024 · 2 comments
Closed

Update CONTRIBUTING.md Regarding Validate filenames Fail #12352

kangaroo-eating-carrots opened this issue Nov 6, 2024 · 2 comments
Labels
enhancement This PR modified some existing files

Comments

@kangaroo-eating-carrots
Copy link

Feature description

I believe it will be helpful if a solution is updated regarding the test failure of Validate files names which the project participants who are using Windows may experience when trying to commit.

image

There was an issue regarding this problem (#8736), I easily fixed it with the comment from jlhuhn (using 'mklink' command).

image

I appreciated his comment, but it believe it will be much better if the solution is added to CONTRIBUTING.md in 'Pre-commit plugin' section as participants can notice this problem after using 'pre-commit run --all-files --show-diff-on-failure'.

Thank you.
@kangaroo-eating-carrots kangaroo-eating-carrots added the enhancement This PR modified some existing files label Nov 6, 2024
@edlerd
Copy link

edlerd commented Nov 11, 2024

I will send a PR for this shortly.

edlerd added a commit to edlerd/Python that referenced this issue Nov 11, 2024
@edlerd
Update contribution guidelines, add note for windows users TheAlgorit…
aeaa6bc 
…hms#12352

Signed-off-by: David Edler <[email protected]>
@edlerd edlerd mentioned this issue Nov 11, 2024
Closed
5 tasks
edlerd added a commit to edlerd/Python that referenced this issue Nov 11, 2024
@edlerd
Update contribution guidelines, add note for windows users TheAlgorit…
21aedc9 
…hms#12352

Signed-off-by: David Edler <[email protected]>
Merged
15 tasks
@kangaroo-eating-carrots
Copy link
Author

This issue is resolved by #12371

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update contribution guidelines, add note for windows users #12352 edlerd/Python
3 participants
@edlerd @kangaroo-eating-carrots and others