Skip to content

WhileLoopFactorial: Optimize and add tests #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 21, 2022
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions Maths/WhileLoopFactorial.js
Original file line number Diff line number Diff line change
@@ -1,15 +1,13 @@
/*
author: Theepag
author: Theepag, optimised by merelymyself
*/
export const factorialize = (num) => {
// Step 1. variable result to store num
let result = num
// If num = 0 OR 1, the factorial will return 1
if (num === 0 || num === 1) { return 1 }
// Step 1. Handles cases where num is 0 or 1, by returning 1.
let result = 1
// Step 2. WHILE loop
while (num > 1) {
result *= num // or result = result * num;
num-- // decrement 1 at each iteration
result = result * num // or result = result * num;
}
// Step 3. Return the factorial
return result
Expand Down
17 changes: 17 additions & 0 deletions Maths/test/WhileLoopFactorial.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import { factorialize } from '../WhileLoopFactorial'

test('Testing on 3!', () => {
expect(factorialize(3)).toBe(6)
})

test('Testing on 7!', () => {
expect(factorialize(7)).toBe(5040)
})

test('Testing on 0!', () => {
expect(factorialize(0)).toBe(1)
})

test('Testing on 12!', () => {
expect(factorialize(12)).toBe(479001600)
})