Skip to content

Add alternative implementation for InsertionSort and relative test. #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2022
Merged

Add alternative implementation for InsertionSort and relative test. #915

merged 1 commit into from
Mar 4, 2022

Conversation

HereBeAndre
Copy link
Contributor

@HereBeAndre HereBeAndre commented Mar 3, 2022 •
edited
Loading

Welcome to the JavaScript community

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@HereBeAndre HereBeAndre changed the title Improve insertion sort algorithm and its description Add alternative implementation for InsertionSort and relative test. Add additional algorithm description Mar 3, 2022
raklaptudirm
raklaptudirm requested changes Mar 4, 2022
View reviewed changes
Copy link
Member

@raklaptudirm raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the tests are failing. Please fix what needs to be fixed.

@HereBeAndre
Copy link
Contributor Author

Looks like the tests are failing. Please fix what needs to be fixed.

Sorry, my bad... Had a typo in test file. Should be alright now.

@raklaptudirm raklaptudirm changed the title Add alternative implementation for InsertionSort and relative test. Add additional algorithm description Add alternative implementation for InsertionSort and relative test. Mar 4, 2022
@raklaptudirm raklaptudirm added feature Adds a new feature algorithm Adds or improves an algorithm Reviewed labels Mar 4, 2022
@raklaptudirm raklaptudirm merged commit 00f5936 into TheAlgorithms:master Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees
No one assigned
Labels
algorithm Adds or improves an algorithm feature Adds a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HereBeAndre @raklaptudirm