Skip to content

Sliding window #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 3, 2021
Merged

Sliding window #833

merged 4 commits into from
Nov 3, 2021

Conversation

Aditya1942
Copy link
Contributor

@Aditya1942 Aditya1942 commented Nov 2, 2021 •
edited
Loading

Welcome to JavaScript community

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@Aditya1942
Copy link
Contributor Author

i have add 2 new solutions to a problem with different complexity.
all guide lines are followed

@raklaptudirm
Copy link
Member

Please move the folder into the Dynamic-Programming/ directory.

@raklaptudirm raklaptudirm added algorithm Adds or improves an algorithm changes required This pull request needs changes feature Adds a new feature labels Nov 2, 2021
Aditya1942
Aditya1942 commented Nov 2, 2021
View reviewed changes
Copy link
Contributor Author

@Aditya1942 Aditya1942 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 new solutions added

@raklaptudirm
Copy link
Member

I asked you to move the Sliding-window directory into the Dynamic-Programming directory.

@Aditya1942
Copy link
Contributor Author

should i move sliding-window folder in dynamic-programming?

@raklaptudirm
Copy link
Member

Yes.

@Aditya1942
Copy link
Contributor Author

Yes.
is it ok ? i mean sliding-window dosen't use Dynamic-Programming concept
i suggest make a separate folder for that

@raklaptudirm
Copy link
Member

Sliding window IS a part of dynamic programming, so it should be inside that folder. Also, sliding window is not a broad category of algorithms, it is a category of dynamic programming.

@Aditya1942
Copy link
Contributor Author

Sliding window IS a part of dynamic programming, so it should be inside that folder. Also, sliding window is not a broad category of algorithms, it is a category of dynamic programming.

ok

@Aditya1942
Copy link
Contributor Author

done.
anything else?

@Aditya1942
Copy link
Contributor Author

Aditya1942 commented Nov 3, 2021 •
edited
Loading

@raklaptudirm
hey can we merge this now

@raklaptudirm raklaptudirm merged commit 308b022 into TheAlgorithms:master Nov 3, 2021
@raklaptudirm raklaptudirm added Reviewed and removed changes required This pull request needs changes labels Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees
No one assigned
Labels
algorithm Adds or improves an algorithm feature Adds a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Aditya1942 @raklaptudirm