Update keyFinder.js #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
winsonrich
commented
Oct 31, 2018
winsonrich
commented
- modified used the suitable identifier for the variables
- leave the loop when a key is match and found to increase the speed of searching in this stage of development
modified used the suitable identifier for the variables
|
This pull request introduces 1 alert when merging 6c894a2 into 9cabd46 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
1. modified the identifiers and used the suitable identifiers for the variables 2. leave the loop when a key is match and found to increase the speed of searching in this stage of development 3. return the key number if founded, return 0 if found nothing
winsonrich
commented
Oct 31, 2018
|
This pull request introduces 1 alert when merging a93d5cf into 9cabd46 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
a sub-function is used to assist the keyfinder to find the key
winsonrich
commented
Oct 31, 2018
|
This pull request introduces 1 alert when merging fed5d51 into 9cabd46 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
Finally, there are several changes in the function keyFinder(str) that make it works well
winsonrich
commented
Oct 31, 2018
Add some key words to the wordbank to increase the chance of the matching.
winsonrich
commented
Oct 31, 2018
ms10398
approved these changes
Mar 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.