Create keyFinder.js #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Find and retrieve the encryption key automatically Note: This is a draft version, please help to modify, Thanks!
ms10398
requested changes
Oct 26, 2018
winsonrich
commented
Oct 27, 2018
|
This pull request introduces 1 alert when merging 5a75bca into 7b82729 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
optimized the indentation for the if statement in line 18
winsonrich
commented
Oct 27, 2018
|
This pull request introduces 1 alert when merging e0fa99b into 7b82729 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
ms10398
reviewed
Oct 27, 2018
some changes is made to optimize the function
|
This pull request introduces 1 alert when merging e41ad76 into 7b82729 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
winsonrich
commented
Oct 27, 2018
ms10398
requested changes
Oct 29, 2018
Made 2 changes to optimize the match results: 1. use a loop to find the next digit of wordbank element and compare with outStr's digit 2. this part need to be optimize with the calculation of the number of occurance of word's probabilities
winsonrich
commented
Oct 30, 2018
ms10398
approved these changes
Oct 30, 2018
|
I would like you to see this article for usage of let and const instead of var https://medium.com/javascript-scene/javascript-es6-var-let-or-const-ba58b8dcde75 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Find and retrieve the encryption key automatically
Note: This is a draft version, please help to modify, Thanks!