Skip to content

Create findRelativeMaximumPointCount.js #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Oct 28, 2021
Merged

Create findRelativeMaximumPointCount.js #771

merged 16 commits into from
Oct 28, 2021

Conversation

jhonDoe15
Copy link
Contributor

print number of relative maximum points in array
runs in O(n)

Welcome to JavaScript community

Open in Gitpod know more

Describe your change:

  • Add an algorithm?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized. (used pieces from other places but the final product and algorithm is mine and mine only)
  • [ x] I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.

@jhonDoe15
Create find_relative_maximum_point_count.js
d70df40 
print number of relative maximum points in array
runs in O(n)
@jhonDoe15 jhonDoe15 changed the title Create find_relative_maximum_point_count.js Create findRelativeMaximumPointCount.js Oct 10, 2021
raklaptudirm
raklaptudirm requested changes Oct 20, 2021
View reviewed changes
Copy link
Member

@raklaptudirm raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add explanatory comments.

@raklaptudirm raklaptudirm added algorithm Adds or improves an algorithm changes required This pull request needs changes feature Adds a new feature Reviewed labels Oct 20, 2021
@raklaptudirm
Copy link
Member

@cclauss

@raklaptudirm raklaptudirm requested a review from cclauss October 21, 2021 09:15
@jhonDoe15
Copy link
Contributor Author

All taken care of as requested and suggested

cclauss
cclauss reviewed Oct 27, 2021
View reviewed changes
raklaptudirm
raklaptudirm requested changes Oct 28, 2021
View reviewed changes
Copy link
Member

@raklaptudirm raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move test file into /test folder.

@raklaptudirm raklaptudirm removed the changes required This pull request needs changes label Oct 28, 2021
raklaptudirm
raklaptudirm requested changes Oct 28, 2021
View reviewed changes
Copy link
Member

@raklaptudirm raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the changes to package-lock.json.

@raklaptudirm raklaptudirm merged commit 9ad93c7 into TheAlgorithms:master Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss left review comments

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees
No one assigned
Labels
algorithm Adds or improves an algorithm feature Adds a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhonDoe15 @raklaptudirm @cclauss