Adding an algorithm AlphaNumericPalindrome from freecodecamp

[SyedFasiuddin]

Welcome to JavaScript community

 know more

Describe your change:

• Add an algorithm?
• Fix a bug or typo in an existing algorithm?
• Documentation change?

Checklist:

• I have read CONTRIBUTING.md.
• This pull request is all my own work -- I have not plagiarized.
• I know that pull requests will not be merged if they fail the automated tests.
• This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
• All new JavaScript files are placed inside an existing directory.
• All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
  Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
• All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
• If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

[SyedFasiuddin]

I think I have done all my checks of naming convention and ES6 syntax among others.

[SyedFasiuddin]

can I get a review and workflow approval please

[raklaptudirm]

@cclauss Would you consider this as a proper algorithm?

[cclauss]

I don’t do JavaScript so I cannot comment on efficiency but I would have written this as return isPalandrome(s) and isAlphaNumeric(s). In Python, each of those functions would be one-liners.

It does however seem to fit the definition of an algorithm unless I am missing something.

[SyedFasiuddin]

I don’t do JavaScript so I cannot comment on efficiency but I would have written this as return isPalandrome(s) and isAlphaNumeric(s). In Python, each of those functions would be one-liners.

It does however seem to fit the definition of an algorithm unless I am missing something.

Yes this can be done in two line in JS as well but, this repository being beginner friendly, I wanted to make it as simple as possible, and if you not include the comments and empty lines this function only takes 8 lines

[SyedFasiuddin]

This error that is popping up saying "unnecessary escape character" in file "Javascript\String\test\AlphaNumericPalindrome.test.js" at lines 8 and 12 is actually inside a string and is a test case requirement, so I don't think this error is any significant in this case.

[cclauss]

A Python version with tests included…

from string import ascii_letters, digits


def is_alphanumeric_palendrome(s: str) -> bool:
    """
    To test, run: `python3 -m doctest v alphanumeric_palendrome.py`
    >>> is_alphanumeric_palendrome("eye")
    True
    >>> is_alphanumeric_palendrome("0_0 (: /-\ :) 0-0")
    True
    >>> is_alphanumeric_palendrome("five|\_/|four")
    False
    >>> is_alphanumeric_palendrome("A man, a plan, a canal. Panama")
    True
    >>> is_alphanumeric_palendrome(" eye for of 1 eye.")
    False
    """
    s = "".join(char for char in s if char in ascii_letters + digits).lower()
    return s == "".join(reversed(s))

[cclauss]

this can be done in two line in JS

For my edification, can you please show me here?

[SyedFasiuddin]

For my edification, can you please show me here?

const alphaNumericPlaindrome = (str) => {
    const string = str.replace(/[^a-zA-Z0-9]*/g, '').toLowerCase()
    return string === string.split('').reverse().join('')
}

Here you go, this will work exactly as your Python code but there is nothing like doctest in js so...

[cclauss]

https://github.com/davidchambers/doctest

[raklaptudirm]

We actually removed all the doctests and migrated all of them to jest. Since it is a proper algorithm, I am marking it as valid.

[raklaptudirm]

Please format your code using standard.js.

[SyedFasiuddin]

fixed it