Proposal: Clean up CI job a bit #727
Conversation
|
Sweet! The "Continuous Integration" job looks quite nice now, doesn't it? |
|
The job that's updating the DIRECTORY.md file has been cleaned up quite a bit, too. It's now faster and only creates a commit when there's actually a change. |
|
This pull request introduces 1 alert and fixes 4 when merging 50638f2 into c1b6fca - view on LGTM.com new alerts:
fixed alerts:
|
|
Could you fix the emerged issues? |
|
I did not really introduce a new bug - I just applied |
|
This pull request fixes 4 alerts when merging 7a9de4c into 17ac987 - view on LGTM.com fixed alerts:
|
|
@cclauss knows better about these files than me, please wait for their review. |
|
@defaude Please resolve the conflicts so that it can be merged. |
raklaptudirm
added
Reviewed
and removed
on hold
|
This job OVERWRITES DIRECTORY.md. |
relates to ##720 Cleaned up and updated the job description file a bit. Instead of attempting to commit every single time, we check if the DIRECTORY file actually has changes first.
Uses globby to find all algorithm files. This is way quicker and less error-prone than the previous implementation. Plus, it allows us to fine-tune excludes (e.g. test files and the babel config). This also removes the need for setTimeouts which greatly speeds up the whole thing.
|
The only conflict is the auto-generated DIRECTORY.md - and yes, this job deliberately overwrites this file (and has been doing so for quite some time before my refactoring, after all) ;) I just updated it once more by rebasing on the current master - let's just hope no other changes are streaming in ;) |
|
This pull request fixes 4 alerts when merging 565ce68 into 90b04ea - view on LGTM.com fixed alerts:
|
relates to #586 and #720
Added npm scripts for doctest and style checking via standard. This allows us to call those directly via npm and not via npx.
The CI job itself is now split into distinct steps (makes it more visible which step failed).