Added Temperature Conversions to Javascript #705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added a file which contains essential conversions needed to swap temperature units to one another. Hope you like it :)
raklaptudirm
requested changes
Oct 2, 2021
Suggestions saved Co-authored-by: Rak Laptudirm <[email protected]>
|
I will add tests file also.Kindly give me some time :) Will add it soon |
|
Please mark the Pull request as |
"test" folder was created and tests required for "TemperatureConversions" was added to it
|
I have added the test file @raklaptudirm |
|
Please fix the tests, they are failing. |
raklaptudirm
added
algorithm
|
@raklaptudirm It was actually some parenthesis error. I fixed it. Actually I created test file with the help of already available file at "math" section. Should I import anything like mocha (for testing) in this folder which I created or is it configured ? Kindly check it and confirm |
raklaptudirm
requested changes
Oct 6, 2021
Co-authored-by: Rak Laptudirm <[email protected]>
The code was modified to comply with rules and styes recommended by the repository
The code was modified to comply with rules and styes recommended by the repository
|
The style checks are failing, please format your code again. |
raklaptudirm
added
code style issue
Hope this passes the test :)
raklaptudirm
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a file which contains essential conversions needed to swap temperature units to one another.
Hope you like it :)