Skip to content

Tests check anagrams #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 23, 2021

Conversation

charliejmoore
Copy link
Contributor

Welcome to JavaScript community

Open in Gitpod know more

Describe your change:

Add additional test cases to CheckAnagrams to include expanded inputs and edge cases.

  • [x ] Add tests?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not

Copy link
Member

@raklaptudirm raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you could, can you change the test cases and the function so that is returns true or false instead of string?

@charliejmoore
Copy link
Contributor Author

If you could, can you change the test cases and the function so that is returns true or false instead of string?

Sure thing! I'll keep that in mind if I come across this in the future too. I think I noticed a similar pattern in other files.

@raklaptudirm
Copy link
Member

Looks good to me.

@raklaptudirm raklaptudirm merged commit 19970c3 into TheAlgorithms:master Sep 23, 2021
@charliejmoore charliejmoore deleted the tests-check-anagrams branch October 4, 2021 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants