Skip to content

Improved CocktailShakerSort and added Doctests #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 18, 2020
Merged

Improved CocktailShakerSort and added Doctests #545

merged 7 commits into from
Dec 18, 2020

Conversation

marsonya
Copy link
Contributor

@marsonya marsonya commented Nov 2, 2020

Here are the changes I made in the Sorts/CocktailShakerSort.js file:

  • Improved Comments and Formatting.
  • The function in CocktailShakerSort was not returning the array. Changed that.
  • Improved the Implementation Examples and Console logs.
  • And Finally, added doctests as mentioned in (Issue #142)
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not

@marsonya
Copy link
Contributor Author

marsonya commented Dec 4, 2020

Hey @itsvinayak, this PR is ready to be merged after your review. It's been open for a month. Kindly take a look.

@marsonya marsonya requested a review from cclauss December 16, 2020 12:52
@marsonya marsonya merged commit 1abd3aa into TheAlgorithms:master Dec 18, 2020
@marsonya marsonya deleted the doctests/cocktail-shaker-sort branch January 12, 2021 18:09
@marsonya marsonya restored the doctests/cocktail-shaker-sort branch January 12, 2021 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss Awaiting requested review from cclauss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@marsonya